public inbox for
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <>
Subject: [Bug default/27213] alt_clear_dups: Assertion `child->die_dup == NULL' failed.
Date: Wed, 20 Jan 2021 15:46:59 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
It doesn't help with this case. But reviewing the code I found that there was
at least one place where we didn't hash the DW_FORM_implicit_const value in
checksum_die meaning that two DIEs which only differed in an attribute (which
we didn't already handle specially) using a DW_FORM_implicit_const with a
different value (maybe a DW_AT_byte_size) could possibly hash to the same

diff --git a/dwz.c b/dwz.c
index 308bcba..e556dfb 100644
--- a/dwz.c
+++ b/dwz.c
@@ -3580,7 +3580,11 @@ checksum_die (DSO *dso, dw_cu_ref cu, dw_die_ref
top_die, dw_die_ref die)
          ptr += ptr_size;
        case DW_FORM_flag_present:
+         break;
        case DW_FORM_implicit_const:
+         if (! handled)
+           die->u.p1.die_hash
+             = iterative_hash_object (t->values[i], die->u.p1.die_hash);
        case DW_FORM_flag:
        case DW_FORM_data1:

You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2021-01-20 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 10:23 [Bug default/27213] New: " jakub at redhat dot com
2021-01-20 15:46 ` mark at klomp dot org [this message]
2021-01-20 20:03 ` [Bug default/27213] " jakub at redhat dot com
2021-01-20 20:13 ` jakub at redhat dot com
2021-01-20 20:22 ` jakub at redhat dot com
2021-01-20 20:34 ` jakub at redhat dot com
2021-01-20 20:48 ` mark at klomp dot org
2021-01-20 20:53 ` mark at klomp dot org
2021-01-21  7:58 ` jakub at redhat dot com
2021-02-08 15:52 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).