public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27363] Emit more detailed diagnostic output for "Unknown DWARF"
Date: Sun, 21 Feb 2021 16:38:57 +0000	[thread overview]
Message-ID: <bug-27363-11298-s2Ncl4SXB8@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27363-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27363

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
The following commits address some of difficulty tracking down where the bad
DWARF was detected. They don't go so far as your suggestions, but I believe
they are already useful. Trying to get more information than the current (DIE)
offsets might also be tricky when we are dealing with bad DWARF.

commit 1e2beb218060515eb1e4f54a0ff6b3714b532e31 (HEAD -> master)
Author: Mark Wielaard <mark@klomp.org>
Date:   Sun Feb 21 16:55:17 2021 +0100

    Print abbrev or DIE offset for Unknown DWARF error message.

            * dwz.c (read_abbrev): Add .debug_abbrev offset to error message.
            (read_exprloc): Print DIE offset that referenced the unknown
            operand in error message.
            (read_expr_low_mem_phase1): Likewise.
            (read_debug_info): Add die_offset to error messages for unknown
            forms, attributes extending beyond end of CU or unknown block
            form attributes.

    https://sourceware.org/bugzilla/show_bug.cgi?id=27363

commit 4705796eb538761db37d5e4ef42171f08c394a65
Author: Mark Wielaard <mark@klomp.org>
Date:   Tue Jan 26 21:12:18 2021 +0100

    Add DIE offsets in error messages to make it easier to find what is wrong.

    With the following patch dwz will give a message like:

    libmozjs-78.so: Couldn't find DIE at [bd6b507] referenced by
      DW_AT_abstract_origin from DIE at [bd5bb9b]

    Which makes it a easier to figure out what is going on.

    In the above case you can simply lookup the producer of the CU for those
    two DIEs. Which turned out the be "clang LLVM (rustc version 1.49.0)"
    which seems to have gotten the abstract origin reference wrong.

            * dwz.c (read_exprloc): Add DIE offsets to error messages.
            (checksum_die): Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2021-02-21 16:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07 11:06 [Bug default/27363] New: " d.filder at web dot de
2021-02-21 16:38 ` mark at klomp dot org [this message]
2022-06-30 13:26 ` [Bug default/27363] " mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27363-11298-s2Ncl4SXB8@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).