From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id DA254385782E; Tue,  9 Feb 2021 07:42:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA254385782E
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27368] [dwz, dwarf5] Handle .debug_macro version 5
Date: Tue, 09 Feb 2021 07:42:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: resolution bug_status
Message-ID: <bug-27368-11298-3mpCCEh7Jv@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27368-11298@http.sourceware.org/bugzilla/>
References: <bug-27368-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Feb 2021 07:42:11 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27368

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Mark Wielaard from comment #7)
> The version check should be fine.
> My preference would simply be version !=3D 4 && version !=3D5.
>=20
> This should fine as is with GCC DWARF5 since:
>=20
>     DW_MACRO_GNU_define =3D=3D              DW_MACRO_define
>     DW_MACRO_GNU_undef =3D=3D               DW_MACRO_undef
>     DW_MACRO_GNU_start_file =3D=3D          DW_MACRO_start_file
>     DW_MACRO_GNU_end_file =3D=3D            DW_MACRO_end_file
>     DW_MACRO_GNU_define_indirect =3D=3D     DW_MACRO_define_strp
>     DW_MACRO_GNU_undef_indirect =3D=3D      DW_MACRO_undef_strp
>     DW_MACRO_GNU_transparent_include =3D=3D DW_MACRO_import
>=20
> That leaves:
>=20
>     DW_MACRO_define_strx
>     DW_MACRO_undef_strx
>=20
> But those are never generated by GCC (see also DW_FORM_strx[1234] support=
).
>=20
> dwz itself could generate (probably behind a --dwarf5 flag):
>=20
>     DW_MACRO_define_sup
>     DW_MACRO_undef_sup
>     DW_MACRO_import_sup

Thanks for the detailed explanation.

I'm closing this PR, since I understand from this that .debug_macro 5 is now
sufficiently supported.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=