public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/27372] New: [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n>
@ 2021-02-08 12:54 vries at gcc dot gnu.org
  2021-02-08 12:56 ` [Bug default/27372] " vries at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-02-08 12:54 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27372

            Bug ID: 27372
           Summary: [dwz] DWARF CU type DW_UT_type unhandled -- Could not
                    find DWARF abbreviation <n>
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot gnu.org
                CC: dwz at sourceware dot org
  Target Milestone: ---

...
$ gcc -gdwarf-5 -fdebug-types-section ../src/testsuite/dwz.tests/hello.c 
$ ./dwz a.out
./dwz: a.out: DWARF CU type DW_UT_type unhandled
./dwz: a.out: Could not find DWARF abbreviation 8620
....

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug default/27372] [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n>
  2021-02-08 12:54 [Bug default/27372] New: [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n> vries at gcc dot gnu.org
@ 2021-02-08 12:56 ` vries at gcc dot gnu.org
  2021-02-08 14:30 ` mark at klomp dot org
  2021-02-09  7:35 ` vries at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-02-08 12:56 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27372

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Looks like a missing goto fail:
...
diff --git a/dwz.c b/dwz.c
index 10860bf..c0d0003 100644
--- a/dwz.c
+++ b/dwz.c
@@ -6584,9 +6584,11 @@ read_debug_info (DSO *dso, int kind, unsigned int
*die_count)
        {
          value = read_8 (ptr);
          if (value != DW_UT_compile && value != DW_UT_partial)
-           error (0, 0, "%s: DWARF CU type %s unhandled", dso->filename,
-                  get_DW_UT_str (value));
-
+           {
+             error (0, 0, "%s: DWARF CU type %s unhandled", dso->filename,
+                    get_DW_UT_str (value));
+             goto fail;
+           }
        }
       else
        {
...
after which we have:
...
$ ./dwz a.out
./dwz: a.out: DWARF CU type DW_UT_type unhandled
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug default/27372] [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n>
  2021-02-08 12:54 [Bug default/27372] New: [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n> vries at gcc dot gnu.org
  2021-02-08 12:56 ` [Bug default/27372] " vries at gcc dot gnu.org
@ 2021-02-08 14:30 ` mark at klomp dot org
  2021-02-09  7:35 ` vries at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2021-02-08 14:30 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27372

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Tom de Vries from comment #1)
> Looks like a missing goto fail:
> ...
> diff --git a/dwz.c b/dwz.c
> index 10860bf..c0d0003 100644
> --- a/dwz.c
> +++ b/dwz.c
> @@ -6584,9 +6584,11 @@ read_debug_info (DSO *dso, int kind, unsigned int
> *die_count)
>         {
>           value = read_8 (ptr);
>           if (value != DW_UT_compile && value != DW_UT_partial)
> -           error (0, 0, "%s: DWARF CU type %s unhandled", dso->filename,
> -                  get_DW_UT_str (value));
> -
> +           {
> +             error (0, 0, "%s: DWARF CU type %s unhandled", dso->filename,
> +                    get_DW_UT_str (value));
> +             goto fail;
> +           }
>         }
>        else
>         {
> ...
> after which we have:
> ...
> $ ./dwz a.out
> ./dwz: a.out: DWARF CU type DW_UT_type unhandled
> ...

Yes, please apply. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug default/27372] [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n>
  2021-02-08 12:54 [Bug default/27372] New: [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n> vries at gcc dot gnu.org
  2021-02-08 12:56 ` [Bug default/27372] " vries at gcc dot gnu.org
  2021-02-08 14:30 ` mark at klomp dot org
@ 2021-02-09  7:35 ` vries at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-02-09  7:35 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27372

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed by this commit: 

https://sourceware.org/git/?p=dwz.git;a=commit;h=2d478ce675aec6642bc036a9ec9a9932ba64edec

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-09  7:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 12:54 [Bug default/27372] New: [dwz] DWARF CU type DW_UT_type unhandled -- Could not find DWARF abbreviation <n> vries at gcc dot gnu.org
2021-02-08 12:56 ` [Bug default/27372] " vries at gcc dot gnu.org
2021-02-08 14:30 ` mark at klomp dot org
2021-02-09  7:35 ` vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).