From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 6B5B73854803; Sun, 14 Feb 2021 22:30:28 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B5B73854803
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27418] DW_FORM_implicit_const handling in checksum_die
 missing attribute hashing
Date: Sun, 14 Feb 2021 22:30:28 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-27418-11298-BNJAPD6zK8@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27418-11298@http.sourceware.org/bugzilla/>
References: <bug-27418-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Feb 2021 22:30:28 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27418

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
I think you are right. The bug seems to be the handled =3D true; That is not
true, we haven't yet handled the attribute completely. We just added the va=
lue
to the hash. The code should then continue so it ends up at the block at the
end after the switch statement:

      if (!handled && die->die_ck_state !=3D CK_BAD)
        {
          s =3D t->attr[i].attr;
          die->u.p1.die_hash =3D iterative_hash_object (s, die->u.p1.die_ha=
sh);
          die->u.p1.die_hash
            =3D iterative_hash (old_ptr, ptr - old_ptr, die->u.p1.die_hash);
        }

--=20
You are receiving this mail because:
You are on the CC list for the bug.=