* [Bug default/27429] New: [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite
@ 2021-02-16 22:13 vries at gcc dot gnu.org
2021-02-23 8:02 ` [Bug default/27429] " vries at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-02-16 22:13 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=27429
Bug ID: 27429
Summary: [dwz, testsuite] mode 4 in checksum_ref_die not
exercised in test-suite
Product: dwz
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
The function checksum_ref_die has four different modes.
I added mode detection at the start of the function, to see which would be
triggered by the testsuite.
Modes 1, 2 and 3 are all triggered.
But not mode 4, also not in the external test suite.
This:
...
@@ -4306,7 +4321,7 @@ checksum_ref_die (dw_cu_ref cu, dw_die_ref top_die,
dw_die_ref die,
}
}
}
- if (minidx != -1U)
+ if (false && minidx != -1U)
{
idx = 0;
checksum_ref_die (die_cu (arr[minidx]), arr[minidx],
...
forces to use mode 4 instead of mode 3.
No issues found in test-suite.
This slows down the external testsuite. These tests pass:
...
PASS: /home/vries/dwz/dwz.git/testsuite/dwz-external.tests/kernel-32.sh
PASS: /home/vries/dwz/dwz.git/testsuite/dwz-external.tests/pr24204.sh
PASS: /home/vries/dwz/dwz.git/testsuite/dwz-external.tests/pr24195.sh
...
but kernel.sh is either hanging or very slow. I presume the same will happen
with kernel-multifile.sh.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/27429] [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite
2021-02-16 22:13 [Bug default/27429] New: [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite vries at gcc dot gnu.org
@ 2021-02-23 8:02 ` vries at gcc dot gnu.org
2021-03-02 7:52 ` vries at gcc dot gnu.org
2021-03-08 13:26 ` vries at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-02-23 8:02 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=27429
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/dwz/2021q1/000957.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/27429] [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite
2021-02-16 22:13 [Bug default/27429] New: [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite vries at gcc dot gnu.org
2021-02-23 8:02 ` [Bug default/27429] " vries at gcc dot gnu.org
@ 2021-03-02 7:52 ` vries at gcc dot gnu.org
2021-03-08 13:26 ` vries at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-02 7:52 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=27429
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/27429] [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite
2021-02-16 22:13 [Bug default/27429] New: [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite vries at gcc dot gnu.org
2021-02-23 8:02 ` [Bug default/27429] " vries at gcc dot gnu.org
2021-03-02 7:52 ` vries at gcc dot gnu.org
@ 2021-03-08 13:26 ` vries at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-08 13:26 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=27429
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed in
https://sourceware.org/git/?p=dwz.git;a=commit;h=64c5452cc94e389a81c5669e0b346c9d79b8ca41
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-08 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 22:13 [Bug default/27429] New: [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite vries at gcc dot gnu.org
2021-02-23 8:02 ` [Bug default/27429] " vries at gcc dot gnu.org
2021-03-02 7:52 ` vries at gcc dot gnu.org
2021-03-08 13:26 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).