From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27429] New: [dwz, testsuite] mode 4 in checksum_ref_die not exercised in test-suite
Date: Tue, 16 Feb 2021 22:13:26 +0000 [thread overview]
Message-ID: <bug-27429-11298@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=27429
Bug ID: 27429
Summary: [dwz, testsuite] mode 4 in checksum_ref_die not
exercised in test-suite
Product: dwz
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
The function checksum_ref_die has four different modes.
I added mode detection at the start of the function, to see which would be
triggered by the testsuite.
Modes 1, 2 and 3 are all triggered.
But not mode 4, also not in the external test suite.
This:
...
@@ -4306,7 +4321,7 @@ checksum_ref_die (dw_cu_ref cu, dw_die_ref top_die,
dw_die_ref die,
}
}
}
- if (minidx != -1U)
+ if (false && minidx != -1U)
{
idx = 0;
checksum_ref_die (die_cu (arr[minidx]), arr[minidx],
...
forces to use mode 4 instead of mode 3.
No issues found in test-suite.
This slows down the external testsuite. These tests pass:
...
PASS: /home/vries/dwz/dwz.git/testsuite/dwz-external.tests/kernel-32.sh
PASS: /home/vries/dwz/dwz.git/testsuite/dwz-external.tests/pr24204.sh
PASS: /home/vries/dwz/dwz.git/testsuite/dwz-external.tests/pr24195.sh
...
but kernel.sh is either hanging or very slow. I presume the same will happen
with kernel-multifile.sh.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2021-02-16 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 22:13 vries at gcc dot gnu.org [this message]
2021-02-23 8:02 ` [Bug default/27429] " vries at gcc dot gnu.org
2021-03-02 7:52 ` vries at gcc dot gnu.org
2021-03-08 13:26 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27429-11298@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).