From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D4533397300F; Fri, 26 Feb 2021 16:58:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4533397300F From: "mark at klomp dot org" To: dwz@sourceware.org Subject: [Bug default/27463] [dwz] Unhandled DW_FORM_sdata for DW_AT_decl_line Date: Fri, 26 Feb 2021 16:58:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: dwz X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: nobody at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 16:58:21 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27463 Mark Wielaard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Mark Wielaard --- commit 4ac908446df75cec7eb8d52399ed58da59120787 (HEAD -> master, origin/mas= ter, origin/HEAD, decl_sdata) Author: Mark Wielaard Date: Fri Feb 26 15:38:58 2021 +0100 PR27463 Accept DW_FORM_sdata for DW_AT_decl/call_file Using DW_FORM_sdata for DW_AT_decl/call_file is somewhat inefficient since file index numbers are always positive values. But it is a valid form to encode a constant value. Accept DW_FORM_sdata as long as it encodes a positive value. Extend the positive value check to DW_FORM_implicit_const. * dwz.c (checksum_die): Accept DW_FORM_sdata for DW_AT_decl/call_file as long as the value is positive. Also check DW_FORM_implicit_const value is positive for these attributes. (die_eq_1): Handle DW_FORM_sdata for DW_AT_decl/call_file. (build_abbrevs_for_die): Likewise. (write_die): Likewise. * testsuite/dwz.tests/pr27463.sh: New test. * testsuite/lib/unavailable-dwarf-piece.exp: New testfile from gdb. * testsuite/dwz.tests/dwz-tests.exp: Add unavailable-dwarf-piece for pr25109.sh. * testsuite/dwz.tests/main.c (foo): New function and labels. (bar): Likewise. * Makefile (TEST_EXECS_DWARF_ASM): Add unavailable-dwarf-piece. https://sourceware.org/bugzilla/show_bug.cgi?id=3D27463 --=20 You are receiving this mail because: You are on the CC list for the bug.=