From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id BC0053851C16; Thu, 25 Feb 2021 14:10:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC0053851C16
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27466] New: [dwz] Improve heuristics for odr
Date: Thu, 25 Feb 2021 14:10:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: dwz
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nobody at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-27466-11298@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Feb 2021 14:10:30 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27466

            Bug ID: 27466
           Summary: [dwz] Improve heuristics for odr
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot gnu.org
                CC: dwz at sourceware dot org
  Target Milestone: ---

In partition_dups_1, we use heuristics to decide whether to convert a parti=
tion
into a partial unit.

These heuristics use the number of unique referrer CUs, registered in the c=
nt
variable.

This cnt is used to compute both:
- the current size of the partition:
  "orig_size =3D size * cnt;"=20
- to size of imports of partial unit to be created:
  "+ (part_lang !=3D 0 ? 0 : import_size * cnt)".

With odr, the duplicate chain is no longer isomorph, and consequently orig_=
size
cannot any longer be calculated using size * cnt.

Then, the number of unique referrer CUs is the correct number to use for the
number of imports.  But due to recent commit "Fix DW_AT_decl_file for odr
", the cnt variable may be lower than the actual number of unique referrer =
CUs.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=