public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27557] Use threading at sub-file level
Date: Fri, 12 Mar 2021 12:35:38 +0000	[thread overview]
Message-ID: <bug-27557-11298-bXg2SiI4KP@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27557-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27557

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
An interesting question is whether find_dups can be parallelized.

The common resource that is used, is the dup_htab. For an actual insertion, the
htab as a whole needs to be locked.

For comparing, comparing DIEs with different checksums can be done in parallel. 
So, we could fold the ref_checksum to a byte, and use that as in index into an
array of 256 locks.  The problem however is the optimistic marking of DIEs as
duplicates when following references.  Marking those optimistically would also
require acquiring the lock for the corresponding checksum, which opens the door
to deadlock problems. We could mitigate for that by detecting cycles upfront,
and avoiding parallel processing of those, but that would again reduce
effectivity.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-03-12 12:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 13:36 [Bug default/27557] New: " vries at gcc dot gnu.org
2021-03-10 14:31 ` [Bug default/27557] " vries at gcc dot gnu.org
2021-03-10 15:11 ` vries at gcc dot gnu.org
2021-03-12 10:56 ` vries at gcc dot gnu.org
2021-03-12 12:35 ` vries at gcc dot gnu.org [this message]
2021-03-12 12:39 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27557-11298-bXg2SiI4KP@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).