public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27633] low mem memory leaks
Date: Tue, 23 Mar 2021 11:15:20 +0000	[thread overview]
Message-ID: <bug-27633-11298-vftrxJDUWs@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27633-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27633

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Focusing on line 6634, we have:
...
  6631    if (unlikely (op_multifile || rd_multifile || fi_multifile ||
low_mem))
  6632      {
  6633        meta_abbrev_htab
  6634          = htab_try_create (500, meta_abbrev_hash, meta_abbrev_eq,
  6635                             meta_abbrev_del);
  6636        if (meta_abbrev_htab == NULL)
  6637          dwz_oom ();
  6638        to_free = obstack_alloc (&ob2, 1);
  6639      }
...

Doing a debug session while watching meta_abbrev_htab show us the problem.

First, we alloc:
...
Old value = (htab_t) 0x0
New value = (htab_t) 0x64f5e0
read_debug_info (dso=0x64c180, kind=0, die_count=0x0) at dwz.c:6636
6636          if (meta_abbrev_htab == NULL)
...

Then, we alloc again:
...
Old value = (htab_t) 0x64f5e0
New value = (htab_t) 0x651410
read_debug_info (dso=0x64c180, kind=5, die_count=0x0) at
/home/vries/dwz/dwz.git/dwz.c:6636
6636          if (meta_abbrev_htab == NULL)
...
but this time, for .debug_types:
...
(gdb) up
#1  0x0000000000430660 in dwz (file=0x7fffffffe1d4 "hello", 
    outfile=0x7fffffffe1dd "hello.z", res=0x7fffffffdb80, resa=0x0, files=0x0)
    at /home/vries/dwz/dwz.git/dwz.c:15391
15391                  || read_debug_info (dso, DEBUG_TYPES, NULL)
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2021-03-23 11:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 11:05 [Bug default/27633] New: " vries at gcc dot gnu.org
2021-03-23 11:15 ` vries at gcc dot gnu.org [this message]
2021-03-23 11:15 ` [Bug default/27633] " vries at gcc dot gnu.org
2021-03-23 13:19 ` vries at gcc dot gnu.org
2021-03-24 17:08 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27633-11298-vftrxJDUWs@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).