Re: dwz 0.14 release?

[tdevries <tdevries@suse.de>]

On 2021-02-27 00:37, Mark Wielaard wrote:
> Hi,
> 
> I propose we do a release on Monday March 1. Unless people think there
> are still some release critical issues that need to be resolved first.
> 

I'd like to postpone by a week.  I've cleaned up odr state, and now I'd 
like to spent some time on other issues.  In particular, I'd like to fix 
the temp file thingy.

Thanks,
- Tom

> On Fri, Feb 19, 2021 at 02:16:12AM +0100, Mark Wielaard wrote:
>> There are 53 open bugs right now. I looked briefly at all of
>> them. Most are ideas for improvements of various forms. For more
>> optimizations or supporting certain DWARF constructs. A couple simply
>> don't have enough information to replicate the issue. Or are for
>> things that are hard to support, like the mips bug (26738) or the
>> emit-relocs issue (24345).
>> 
>> I don't believe any of the bugs are regressions since 0.13. But the
>> following 6 bugs seem good to take a quick look at to see if a fix is
>> easy, but none of them seem like real showstoppers for a
>> release. Since there are a lot of things fixed and new features since
>> 0.13 I think we should do a release as soon as we know these aren't
>> fixed in a couple of days.
>> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=26252
>> [odr] dwz.c:11404: write_die: Assertion `value && refdcu->cu_kind != 
>> CU_ALT'
>>       failed. #2
>> For which you just posted a patch.
> 
> This (and bug 25439) have been fixed by commit 3312feb17 "Fix CK_BAD
> propagation for --odr".
> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=24275
>> hardlink handling leaves temporary file if not file compressed
>> This is mostly an annoyance, but I haven't figured out the code to fix 
>> it.
> 
> Status still the same.
> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=27401
>> Document that the --odr flag is currently experimental
>> Would be nice to have documented what works and what still needs work
>> There are a couple of ODR bugs for which I didn't know the current
>> status, e.g. Bug 24198 (which is the tracker bug?)
> 
> Documentation patch has been posted:
> https://sourceware.org/pipermail/dwz/2021q1/000980.html
> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=27363
>> Emit more detailed diagnostic output for "Unknown DWARF"
>> This has improved a bit. I don't think we need to go so far as the
>> reporter would like. But we could add a bit more output to some of the
>> errors like we did in commit 4705796eb "Add DIE offsets in error
>> messages to make it easier to find what is wrong."
> 
> With another followup commit 1e2beb218 "Print abbrev or DIE offset for
> Unknown DWARF error message". The error messages can still be
> improved, so lets keep the bug open for now.
> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=25252
>> dwz: returns exit status 1, causing FTBFS in deal.ii
>> This seems partially fixed, but still has a patch that looks
>> plausible, but I don't really know if it is still needed.
> 
> Unclear how to test this. So still open.
> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=25459
>> Forward pseudo-reference triggers error
>> Seems like a real issue. And has a test binary that triggers the
>> issue. On the other hand this test binary is slightly odd. It is
>> referenced in a couple of other bug reports, but it seems unclear how
>> it was ever generated. This might not be easily fixable without adding
>> a new pass over the whole DIE tree. Unless someone has a clever idea.
> 
> No updates.
> 
> Some other bugs updated since last Friday:
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27449
>   dwz: 1: Unknown DWARF DW_OP_0
>   Thanks to the new diagnostics tracked down to possible GCC bug.
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27463
>   [dwz] Unhandled DW_FORM_sdata for DW_AT_decl_line
>   Filed and fixed.
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27474
>   [dwz] Report unknown dwarf problem only once
>   Another request for better error diagnostics
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27438
>   [dwz, odr, multifile] Multifile after odr not optimal
>   Filed and fixed
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=25398
>   [dwz, fixed-needs-testcase] CU referenced from PU
>   Patch posted, needs review:
>   https://sourceware.org/pipermail/dwz/2021q1/000976.html
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=25424
>   CU referenced from PU (--odr-mode=link case)
>   Patch posted, needs review:
>   https://sourceware.org/pipermail/dwz/2021q1/000974.html
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27464
>   CU referenced from PU (--odr-mode=link case) (bis)
>   Patch posted, needs, review:
>   https://sourceware.org/pipermail/dwz/2021q1/000975.html
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27466
>   [dwz] Improve heuristics for odr
>   New enhancement bug
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27429
>   [dwz, testsuite] mode 4 in checksum_ref_die not exercised in 
> test-suite
>   Patch posted, needs review:
>   https://sourceware.org/pipermail/dwz/2021q1/000957.html
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=27440
>   [dwz, dwarf5] Add --dwarf-5 flag to generate .debug_sup, ref_sup and
>   strp_sup
>   Implemented
> 
> - https://sourceware.org/bugzilla/show_bug.cgi?id=24978
>   [dwz] Segmentation fault for two-files-too-many-dies-2.sh on
>   arm-linux-gnueabihf with binutils trunk and gcc-9 branch
>   Resolved, worksforme.
> 
> Cheers,
> 
> Mark