From: "Martin Liška" <mliska@suse.cz>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Use xxHash hashing algorithm.
Date: Mon, 4 Jul 2022 15:31:07 +0200 [thread overview]
Message-ID: <c5620cb0-6159-9205-3ad4-b62f08676f9a@suse.cz> (raw)
In-Reply-To: <9936e9f84660a3a47e7a87567bab131d54fdb221.camel@klomp.org>
>
> OK. dwz.c is fine. But any reason why you picked that instead of
> hashtab.h?
Well, I wanted to have all macro definitions together to the definition
of a static variable:
+/* xxHash state object. */
+static XXH64_state_t state;
>
>>>
>>> How much of hashtab.{c,h} are we still using?
>>
>> wc -l hashtab.[ch]
>> 628 hashtab.c
>> 160 hashtab.h
>> 788 total
>>
>> with my patch.
>
> Ah, right, all the actual hashtable code is still there of course. We
> only replaced the hash, not the datastructure.
Yep, the hash table related stuff is still needed.
>
>> Please take a look at the updated patch.
>
> I read it again and it looks good to me.
Fine. Can I install the patch now or should we wait for a follow up
patch that will come up with a proper configuration?
Cheers,
Martin
>
> Thanks,
>
> Mark
next prev parent reply other threads:[~2022-07-04 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 8:17 Martin Liška
2022-03-31 11:29 ` Martin Liška
2022-04-28 10:06 ` Martin Liška
2022-06-20 13:29 ` Martin Liška
2022-06-25 19:44 ` Mark Wielaard
2022-06-27 13:41 ` Martin Liška
2022-06-30 16:13 ` Mark Wielaard
2022-07-04 13:31 ` Martin Liška [this message]
2022-07-04 15:40 ` Mark Wielaard
2022-07-07 12:29 ` Martin Liška
2022-07-07 13:36 ` xxhash devel on buildbot workers (Was: [PATCH] Use xxHash hashing algorithm) Mark Wielaard
2022-07-07 15:04 ` xxhash devel on buildbot workers Thomas Fitzsimmons
2022-07-11 7:48 ` xxhash devel on buildbot workers (Was: [PATCH] Use xxHash hashing algorithm) Dan Horák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5620cb0-6159-9205-3ad4-b62f08676f9a@suse.cz \
--to=mliska@suse.cz \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).