From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id DA69B38582A7 for ; Mon, 4 Jul 2022 13:31:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA69B38582A7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 155A620039; Mon, 4 Jul 2022 13:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1656941468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UR2airxtk5CpIQSs/zAn6c39xMa054IWXoRpKI/Nf0w=; b=SDipPqBD/jxFwo1FBPljbo+sTXJZlYFZY41I4L472S3GSMwvcEbnQuf/6xF7BqrBrlvBQJ IgIc4Vfpd7Med7QIgN3yyTGdwN1B4+4FSdVTsSNHT5coQeKPnNnNclM0/1c52TODne8KvY 5XuWbeKNErf9z3sx5di/MdfCjdiGnSI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1656941468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UR2airxtk5CpIQSs/zAn6c39xMa054IWXoRpKI/Nf0w=; b=KbH682tlnq86x+Tu3U8eQqrd6x+5hrsSQYRxoSn6oOK9cwi2+I01Q7P7OT17102zjB6wMJ KIfmMYF5l0Dqb3Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F20C61342C; Mon, 4 Jul 2022 13:31:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id URUGOpvrwmJuRgAAMHmgww (envelope-from ); Mon, 04 Jul 2022 13:31:07 +0000 Message-ID: Date: Mon, 4 Jul 2022 15:31:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Use xxHash hashing algorithm. Content-Language: en-US To: Mark Wielaard Cc: dwz@sourceware.org References: <20220625194440.GA16194@gnu.wildebeest.org> <9936e9f84660a3a47e7a87567bab131d54fdb221.camel@klomp.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <9936e9f84660a3a47e7a87567bab131d54fdb221.camel@klomp.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 13:31:10 -0000 > > OK. dwz.c is fine. But any reason why you picked that instead of > hashtab.h? Well, I wanted to have all macro definitions together to the definition of a static variable: +/* xxHash state object. */ +static XXH64_state_t state; > >>> >>> How much of hashtab.{c,h} are we still using? >> >> wc -l hashtab.[ch] >> 628 hashtab.c >> 160 hashtab.h >> 788 total >> >> with my patch. > > Ah, right, all the actual hashtable code is still there of course. We > only replaced the hash, not the datastructure. Yep, the hash table related stuff is still needed. > >> Please take a look at the updated patch. > > I read it again and it looks good to me. Fine. Can I install the patch now or should we wait for a follow up patch that will come up with a proper configuration? Cheers, Martin > > Thanks, > > Mark