public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: lvying <lvying6@huawei.com>
To: <tdevries@suse.de>, <jakub@redhat.com>, <dwz@sourceware.org>
Cc: <fanwentao@huawei.com>
Subject: Re:[PING] [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e)
Date: Mon, 17 Jan 2022 15:44:22 +0800	[thread overview]
Message-ID: <cd6fc176-b661-d93b-d8b7-61f471fdf79c@huawei.com> (raw)
In-Reply-To: <1642022984-19556-1-git-send-email-lvying6@huawei.com>

A gentle reminder to please review this patch.

> The two testcases still failed when using newer readelf(binutils commit c46b706620e):
> testsuite/dwz.tests/odr-struct-multifile.sh
> testsuite/dwz.tests/cycle.sh
> 
> fix the new -Wn readelf flag test
> 
> Signed-off-by: Lv Ying <lvying6@huawei.com>
> ---
>   testsuite/dwz.tests/cycle.sh                | 2 +-
>   testsuite/dwz.tests/odr-struct-multifile.sh | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testsuite/dwz.tests/cycle.sh b/testsuite/dwz.tests/cycle.sh
> index 85aa556..17f8eb5 100644
> --- a/testsuite/dwz.tests/cycle.sh
> +++ b/testsuite/dwz.tests/cycle.sh
> @@ -1,5 +1,5 @@
>   readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
>       readelf_flags=-wN
>   fi
>   
> diff --git a/testsuite/dwz.tests/odr-struct-multifile.sh b/testsuite/dwz.tests/odr-struct-multifile.sh
> index 20b682b..159cbc3 100644
> --- a/testsuite/dwz.tests/odr-struct-multifile.sh
> +++ b/testsuite/dwz.tests/odr-struct-multifile.sh
> @@ -3,7 +3,7 @@ if ! $execs/dwz-for-test --odr -v 2>/dev/null; then
>   fi
>   
>   readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
>       readelf_flags=-wN
>   fi
>   
> 


-- 
Thanks!
Lv Ying

  reply	other threads:[~2022-01-17  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 21:29 Lv Ying
2022-01-17  7:44 ` lvying [this message]
2022-06-25 21:12 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd6fc176-b661-d93b-d8b7-61f471fdf79c@huawei.com \
    --to=lvying6@huawei.com \
    --cc=dwz@sourceware.org \
    --cc=fanwentao@huawei.com \
    --cc=jakub@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).