From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvying6@huawei.com>
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by sourceware.org (Postfix) with ESMTPS id 5F7483858402
 for <dwz@sourceware.org>; Mon, 17 Jan 2022 07:44:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F7483858402
Received: from dggeme758-chm.china.huawei.com (unknown [172.30.72.57])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4JckPC44Hzz8wNQ;
 Mon, 17 Jan 2022 15:41:35 +0800 (CST)
Received: from [10.174.176.219] (10.174.176.219) by
 dggeme758-chm.china.huawei.com (10.3.19.104) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.2308.21; Mon, 17 Jan 2022 15:44:22 +0800
Subject: Re:[PING] [PATCH] [testsuite] fix Handle readelf following links by
 default(b1f26dc76158e)
To: <tdevries@suse.de>, <jakub@redhat.com>, <dwz@sourceware.org>
CC: <fanwentao@huawei.com>
References: <1642022984-19556-1-git-send-email-lvying6@huawei.com>
From: lvying <lvying6@huawei.com>
Message-ID: <cd6fc176-b661-d93b-d8b7-61f471fdf79c@huawei.com>
Date: Mon, 17 Jan 2022 15:44:22 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <1642022984-19556-1-git-send-email-lvying6@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.174.176.219]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggeme758-chm.china.huawei.com (10.3.19.104)
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: dwz@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Dwz mailing list <dwz.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/dwz>,
 <mailto:dwz-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/dwz/>
List-Help: <mailto:dwz-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/dwz>,
 <mailto:dwz-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Jan 2022 07:44:28 -0000

A gentle reminder to please review this patch.

> The two testcases still failed when using newer readelf(binutils commit c46b706620e):
> testsuite/dwz.tests/odr-struct-multifile.sh
> testsuite/dwz.tests/cycle.sh
> 
> fix the new -Wn readelf flag test
> 
> Signed-off-by: Lv Ying <lvying6@huawei.com>
> ---
>   testsuite/dwz.tests/cycle.sh                | 2 +-
>   testsuite/dwz.tests/odr-struct-multifile.sh | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testsuite/dwz.tests/cycle.sh b/testsuite/dwz.tests/cycle.sh
> index 85aa556..17f8eb5 100644
> --- a/testsuite/dwz.tests/cycle.sh
> +++ b/testsuite/dwz.tests/cycle.sh
> @@ -1,5 +1,5 @@
>   readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
>       readelf_flags=-wN
>   fi
>   
> diff --git a/testsuite/dwz.tests/odr-struct-multifile.sh b/testsuite/dwz.tests/odr-struct-multifile.sh
> index 20b682b..159cbc3 100644
> --- a/testsuite/dwz.tests/odr-struct-multifile.sh
> +++ b/testsuite/dwz.tests/odr-struct-multifile.sh
> @@ -3,7 +3,7 @@ if ! $execs/dwz-for-test --odr -v 2>/dev/null; then
>   fi
>   
>   readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
>       readelf_flags=-wN
>   fi
>   
> 


-- 
Thanks!
Lv Ying