* [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e)
@ 2022-01-12 21:29 Lv Ying
2022-01-17 7:44 ` lvying
2022-06-25 21:12 ` Mark Wielaard
0 siblings, 2 replies; 3+ messages in thread
From: Lv Ying @ 2022-01-12 21:29 UTC (permalink / raw)
To: tdevries, jakub, dwz; +Cc: fanwentao, lvying6
The two testcases still failed when using newer readelf(binutils commit c46b706620e):
testsuite/dwz.tests/odr-struct-multifile.sh
testsuite/dwz.tests/cycle.sh
fix the new -Wn readelf flag test
Signed-off-by: Lv Ying <lvying6@huawei.com>
---
testsuite/dwz.tests/cycle.sh | 2 +-
testsuite/dwz.tests/odr-struct-multifile.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testsuite/dwz.tests/cycle.sh b/testsuite/dwz.tests/cycle.sh
index 85aa556..17f8eb5 100644
--- a/testsuite/dwz.tests/cycle.sh
+++ b/testsuite/dwz.tests/cycle.sh
@@ -1,5 +1,5 @@
readelf_flags=""
-if readelf -h 2>&1 | grep -q "\-wN,"; then
+if readelf -h 2>&1 | grep -q "\-wN"; then
readelf_flags=-wN
fi
diff --git a/testsuite/dwz.tests/odr-struct-multifile.sh b/testsuite/dwz.tests/odr-struct-multifile.sh
index 20b682b..159cbc3 100644
--- a/testsuite/dwz.tests/odr-struct-multifile.sh
+++ b/testsuite/dwz.tests/odr-struct-multifile.sh
@@ -3,7 +3,7 @@ if ! $execs/dwz-for-test --odr -v 2>/dev/null; then
fi
readelf_flags=""
-if readelf -h 2>&1 | grep -q "\-wN,"; then
+if readelf -h 2>&1 | grep -q "\-wN"; then
readelf_flags=-wN
fi
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re:[PING] [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e)
2022-01-12 21:29 [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e) Lv Ying
@ 2022-01-17 7:44 ` lvying
2022-06-25 21:12 ` Mark Wielaard
1 sibling, 0 replies; 3+ messages in thread
From: lvying @ 2022-01-17 7:44 UTC (permalink / raw)
To: tdevries, jakub, dwz; +Cc: fanwentao
A gentle reminder to please review this patch.
> The two testcases still failed when using newer readelf(binutils commit c46b706620e):
> testsuite/dwz.tests/odr-struct-multifile.sh
> testsuite/dwz.tests/cycle.sh
>
> fix the new -Wn readelf flag test
>
> Signed-off-by: Lv Ying <lvying6@huawei.com>
> ---
> testsuite/dwz.tests/cycle.sh | 2 +-
> testsuite/dwz.tests/odr-struct-multifile.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testsuite/dwz.tests/cycle.sh b/testsuite/dwz.tests/cycle.sh
> index 85aa556..17f8eb5 100644
> --- a/testsuite/dwz.tests/cycle.sh
> +++ b/testsuite/dwz.tests/cycle.sh
> @@ -1,5 +1,5 @@
> readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
> readelf_flags=-wN
> fi
>
> diff --git a/testsuite/dwz.tests/odr-struct-multifile.sh b/testsuite/dwz.tests/odr-struct-multifile.sh
> index 20b682b..159cbc3 100644
> --- a/testsuite/dwz.tests/odr-struct-multifile.sh
> +++ b/testsuite/dwz.tests/odr-struct-multifile.sh
> @@ -3,7 +3,7 @@ if ! $execs/dwz-for-test --odr -v 2>/dev/null; then
> fi
>
> readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
> readelf_flags=-wN
> fi
>
>
--
Thanks!
Lv Ying
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e)
2022-01-12 21:29 [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e) Lv Ying
2022-01-17 7:44 ` lvying
@ 2022-06-25 21:12 ` Mark Wielaard
1 sibling, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2022-06-25 21:12 UTC (permalink / raw)
To: Lv Ying; +Cc: tdevries, jakub, dwz, fanwentao
Hi,
On Thu, Jan 13, 2022 at 05:29:44AM +0800, Lv Ying via Dwz wrote:
> The two testcases still failed when using newer readelf(binutils commit c46b706620e):
> testsuite/dwz.tests/odr-struct-multifile.sh
> testsuite/dwz.tests/cycle.sh
>
> fix the new -Wn readelf flag test
Thanks so much for this patch. And appologies it took so long to
review.
As the commit message says this fixes two failing testcases for me,
odr-struct-multifile.sh and cycle.sh.
And it looks totally correct, even if there are releases of readelf
which put a ',' after "-Wn" it should still work.
Pushed your patch.
Cheers,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-25 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 21:29 [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e) Lv Ying
2022-01-17 7:44 ` lvying
2022-06-25 21:12 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).