Re: [PATCH] Add do-release.sh

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On 29-07-19 19:20, Jakub Jelinek wrote:
> On Mon, Jul 22, 2019 at 09:41:33AM +0200, Tom de Vries wrote:
>> Hi,
>>
>> this commit adds a script that:
>> - bumps either the minor or the major version, using options
>>   --major or --minor
>> - updates VERSION
>> - commits VERSION update
>> - tags VERSION update
>>
>> OK for trunk?
>>
>> Is there anything else involved in doing a release?
> 
> I think that is all, bumping VERSION, commiting and tagging was all I did in
> the past.
> 
> One thing that might be worth doing is bump copyright years on files you've
> modified, I know dwz.c has been using mostly Red Hat copyright, if you want
> to use say FSF copyright, can you change that 2003 in there to 2003, 2019?
> Or do you want to use SUSE copyright instead?

It seems I have to use the SUSE copyright.

> I guess because I have touched dwz.c last year the RH copyright should be
> -2018 instead of -2015 too,

Done.

> and dwarf2.def should be probably changed to
> 1992-2018 FSF copyright, using the simple range.

Done. [ Although, in the dwz.c file you've used 2003 as the FSF
copyright year, due to the contribution date of strrevcmp to
bfd/merge.c. So, using the same logic, we would have to use 2017 as the
FSF copyright year for the 2018 dwz commit which backports a change of
<gcc repo>/include/dwarf2.def from 2017. ]

Also, I've added 2016 to FSF copyright for hashtab.c due to a backport
of code contributed to the gcc repo in 2016. But perhaps that needs to
be 2019?

>  After the release we
> should likely import new dwarf2.def and dwarf2.h from GCC tree.

Agreed.

OK like this?

Thanks,
- Tom


[-- Attachment #2: 0001-Update-copyright.patch --]
[-- Type: text/x-patch, Size: 1550 bytes --]

Update copyright

2019-08-01  Tom de Vries  <tdevries@suse.de>

	* dwarf2.def: Update copyright.
	* dwz.c: Same.
	* hashtab.c: Same.

---
 dwarf2.def | 3 +--
 dwz.c      | 3 ++-
 hashtab.c  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dwarf2.def b/dwarf2.def
index 17311fa..e308ba7 100644
--- a/dwarf2.def
+++ b/dwarf2.def
@@ -1,8 +1,7 @@
 /* -*- c -*-
    Declarations and definitions of codes relating to the DWARF2 and
    DWARF3 symbolic debugging information formats.
-   Copyright (C) 1992, 1993, 1995, 1996, 1997, 1999, 2000, 2001, 2002,
-   2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012
+   Copyright (C) 1992-2018
    Free Software Foundation, Inc.
 
    Written by Gary Funck (gary@intrepid.com) The Ada Joint Program
diff --git a/dwz.c b/dwz.c
index 577ea2c..266f56d 100644
--- a/dwz.c
+++ b/dwz.c
@@ -1,5 +1,6 @@
-/* Copyright (C) 2001-2015 Red Hat, Inc.
+/* Copyright (C) 2001-2018 Red Hat, Inc.
    Copyright (C) 2003 Free Software Foundation, Inc.
+   Copyright (C) 2019 SUSE LLC.
    Written by Jakub Jelinek <jakub@redhat.com>, 2012.
 
    This program is free software; you can redistribute it and/or modify
diff --git a/hashtab.c b/hashtab.c
index a1da33e..59600c0 100644
--- a/hashtab.c
+++ b/hashtab.c
@@ -1,5 +1,5 @@
 /* An expandable hash tables datatype.
-   Copyright (C) 1999, 2000, 2001, 2002, 2003, 2004, 2009, 2010
+   Copyright (C) 1999, 2000, 2001, 2002, 2003, 2004, 2009, 2010, 2016
    Free Software Foundation, Inc.
    Contributed by Vladimir Makarov (vmakarov@cygnus.com).