public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Tom de Vries <tdevries@suse.de>,
	dwz@sourceware.org, Jakub Jelinek <jakub@redhat.com>,
	Mark Wielaard <mark@klomp.org>, Michael Matz <matz@suse.de>
Subject: Re: [Highlight] Performance improvements
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <ea134236-3d9d-c28d-5ef7-52a0ea825014@suse.cz> (raw)
In-Reply-To: <bf7919b7-f446-6cf1-bfc5-60fa725c011e@suse.de>

On 11/26/19 6:59 PM, Tom de Vries wrote:
> Hi,
> 
> I've been working on performance improvements for dwz, using a cc1
> binary as my optimization vehicle.
> 
> Comparing the situation:
> - before (commit 04a676d Add --devel-partition-dups-opt), and
> - after (current master, commit e405c62 Add --devel-die-count-method
>    {none,estimate})
> I get the following results.
> 
> When avoiding running into the low-mem die-limit using -lnone, we get
> ~25% performance improvement, due to an improved hash function and an
> improved hash table allocation strategy (without increasing peak memory
> usage):
> ...
> real:  mean:  7378.10  100.00%  stddev:  45.31
>         mean:  5558.80   75.34%  stddev:  35.18
> user:  mean:  7106.30  100.00%  stddev:  41.53
>         mean:  5328.10   74.98%  stddev:  22.33
> sys:   mean:   271.60  100.00%  stddev:  39.57
>         mean:   230.00   84.68%  stddev:  40.45
> ...
> 
> And if we don't avoid running into the low-mem die-limit, we get ~38%
> performance improvement:
> ...
> real:  mean:  15084.80 100.00%  stddev:  44.53
>         mean:   9232.90  61.21%  stddev:  41.80
> user:  mean:  14759.40 100.00%  stddev:  30.62
>         mean:   9100.10  61.66%  stddev:  41.75
> sys:   mean:    324.00 100.00%  stddev:  39.51
>         mean:    132.00  40.74%  stddev:  27.26
> ...
> which is also paired with a reduction in peak memory usage of ~34%, from
> 0.95GB to 0.63GB, due to running into the low-mem die-limit in a more
> efficient manner.

Hi.

That sounds very promising! I would like to see it being used in our openSUSE
package. Are you planning to use it?

Thanks,
Martin

> 
> Thanks,
> - Tom
> 

  reply	other threads:[~2019-11-27 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 Tom de Vries
2019-01-01  0:00 ` Martin Liška [this message]
2019-01-01  0:00   ` Tom de Vries
2021-12-23 11:57     ` Martin Liška
2022-01-03 22:06       ` Mark Wielaard
2022-01-05  8:01         ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea134236-3d9d-c28d-5ef7-52a0ea825014@suse.cz \
    --to=mliska@suse.cz \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    --cc=mark@klomp.org \
    --cc=matz@suse.de \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).