From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 797463858000 for ; Fri, 1 Jul 2022 06:42:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 797463858000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 831CE21DF0; Fri, 1 Jul 2022 06:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1656657720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=04crAhiAV7wHGxyVzjoYI+Zb0ZxQHE1TykXlDo6QCqM=; b=WLQt406xqECJTXpFuBd+mP3QuypH90yfrGRQPEplZF7Zejsg/bcHW/f6PCnoXIOsnVJArF Tl7opmjAdyV1FZmN4qvvtddWKptGfRtGO7/jWXBYL5FZhPkcOs2HGNCJi4SBTt1+1x0u/3 jGxJRCEcCKCf6gZeUgvN3Vf74EygO+M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1656657720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=04crAhiAV7wHGxyVzjoYI+Zb0ZxQHE1TykXlDo6QCqM=; b=u937nSR98ZUkMejxGAKhtrui/UR29SaXqfH8+UlpyktqQU7CCBWSH8+Yo/S4H2B5vDOdJ4 SqVE7iz2aRDMNNDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 69BDE13484; Fri, 1 Jul 2022 06:42:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id R3mpGDiXvmIDGwAAMHmgww (envelope-from ); Fri, 01 Jul 2022 06:42:00 +0000 Content-Type: multipart/mixed; boundary="------------NOmzMO0mKvshU51YtL1tRO57" Message-ID: Date: Fri, 1 Jul 2022 08:42:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: =?UTF-8?Q?Re=3a_=e2=98=ba_Buildbot_=28GNU_Toolchain=29=3a_dwz_-_bui?= =?UTF-8?Q?ld_successful_=28master=29?= Content-Language: en-US To: Mark Wielaard Cc: dwz@sourceware.org, Tom de Vries References: <20220625215613.349A43851AA8@sourceware.org> <8f2e7627-8084-1148-363f-6ac3b71b87f4@suse.cz> <9b8016f2-b9f4-b310-4a73-692f70e32799@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 06:42:04 -0000 This is a multi-part message in MIME format. --------------NOmzMO0mKvshU51YtL1tRO57 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/30/22 22:05, Mark Wielaard wrote: > Hi Martin, > > On Thu, Jun 30, 2022 at 04:23:02PM +0200, Martin Liška wrote: >> On 6/28/22 23:43, Mark Wielaard wrote: >>> On Mon, Jun 27, 2022 at 09:25:23AM +0200, Martin Liška wrote: >>>> On 6/26/22 00:17, Mark Wielaard wrote: >>>>> The build is now green on all builders except one: >>>>> https://builder.sourceware.org/buildbot/#/builders?tags=dwz >>>>> dwz-opensusetw-x86_64 fails one testcase: odr-struct-ns.sh >>>>> https://builder.sourceware.org/buildbot/#/builders/100/builds/2 >>>>> >>>>> Martin, could you take a look at what is different on tumbleweed from >>>>> the other builders that makes that testcase fail? >>>> >>>> It's going to be likely GCC compiler version that plays role. >>>> >>>> Anyway, it's caused by: >>>> >>>> expected_decl_cnt: 20, decl_cnt: 10 >>> >>> I took a quick look and this seems to be caused by lots of extra >>> DW_AT_declaration in the original binary: >>> >>> readelf -wi odr-struct-ns | grep -3 DW_AT_declaration | grep name >>> <1c0> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at >>> <1d4> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 >>> <1e8> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl >>> <1fc> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon >>> <2c4> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp >>> <2d8> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx >>> <2ec> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso >>> <300> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns >>> <314> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un >>> <328> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 >>> <671> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at >>> <685> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 >>> <699> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl >>> <6ad> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon >>> <770> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp >>> <784> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx >>> <798> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso >>> <7ac> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns >>> <7c0> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un >>> <7d4> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 >>> <9e0> DW_AT_name : bbb >>> DW_AT_name : ccc >> >> Just to summarize it what we have for Tumbleweed and Leap: >> >> TW: >> >> ==before== >> <1c0> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at >> <1d4> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 >> <1e8> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl >> <1fc> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon >> <2c4> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp >> <2d8> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx >> <2ec> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso >> <300> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns >> <314> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un >> <328> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 >> <671> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at >> <685> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 >> <699> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl >> <6ad> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon >> <770> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp >> <784> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx >> <798> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso >> <7ac> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns >> <7c0> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un >> <7d4> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 >> <9e0> DW_AT_name : bbb >> DW_AT_name : ccc >> ==after== >> DW_AT_name : (indirect string, offset: 0x3f1): sockaddr_at >> DW_AT_name : (indirect string, offset: 0x450): sockaddr_ax25 >> <10a> DW_AT_name : (indirect string, offset: 0x366): sockaddr_dl >> <118> DW_AT_name : (indirect string, offset: 0x382): sockaddr_eon >> <1b6> DW_AT_name : (indirect string, offset: 0x5e): sockaddr_inarp >> <1c4> DW_AT_name : (indirect string, offset: 0xa7): sockaddr_ipx >> <1d2> DW_AT_name : (indirect string, offset: 0x51): sockaddr_iso >> <1e0> DW_AT_name : (indirect string, offset: 0x11c): sockaddr_ns >> <1ee> DW_AT_name : (indirect string, offset: 0x86): sockaddr_un >> <1fc> DW_AT_name : (indirect string, offset: 0x3bd): sockaddr_x25 >> >> while Leap has: >> >> ==before== >> <105> DW_AT_name : bbb >> <1cb> DW_AT_name : ccc >> <2b3> DW_AT_name : (indirect string, offset: 0x4b6): __preinit_array_end >> <2be> DW_AT_name : (indirect string, offset: 0x2a5): __init_array_start >> <2c9> DW_AT_name : (indirect string, offset: 0x4ca): __init_array_end >> <2f1> DW_AT_name : (indirect string, offset: 0x2fd): __fini_array_end >> <2fc> DW_AT_name : (indirect string, offset: 0x2ed): __libc_csu_fini >> <3bb> DW_AT_linkage_name: (indirect string, offset: 0x33d): _init >> <3bf> DW_AT_name : (indirect string, offset: 0x33d): _init >> ==after== >> <27e> DW_AT_name : (indirect string, offset: 0x4b6): __preinit_array_end >> <286> DW_AT_name : (indirect string, offset: 0x2a5): __init_array_start >> <28e> DW_AT_name : (indirect string, offset: 0x4ca): __init_array_end >> <2ab> DW_AT_name : (indirect string, offset: 0x2fd): __fini_array_end >> <2b4> DW_AT_name : (indirect string, offset: 0x2ed): __libc_csu_fini >> <34c> DW_AT_linkage_name: (indirect string, offset: 0x33d): _init >> <350> DW_AT_name : (indirect string, offset: 0x33d): _init >> >> So as Florian said, we should ignore sockeraddr decls and check that bbb and ccc >> are not present after dwz. >> >> What about using the following patch? > > That fails on my local debian-arm64 setup. > > Because bbb and ccc were the only DW_AT_declarations in the original > binary. > > $ readelf -wi odr-struct-ns | grep -3 DW_AT_declaration | grep name > <7c> DW_AT_name : bbb > <14b> DW_AT_name : ccc > > So > readelf -wi 1 | grep -3 DW_AT_declaration > decls > fails because the grep fails > > So I think that should also be a passing condition (no decls left). > It would be good to make sure they were there at the start though. > > Cheers, > > Mark > Oh, I see, so please try the updated version of the patch? Cheers, Martin --------------NOmzMO0mKvshU51YtL1tRO57 Content-Type: text/x-patch; charset=UTF-8; name="0001-testsuite-verify-directly-merged-DW_AT_declarations.patch" Content-Disposition: attachment; filename*0="0001-testsuite-verify-directly-merged-DW_AT_declarations.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSBlMDhiNGUzNjE1NDZkNGRiNzczYjM5NDgyNDFiNTg2ZmE1ZWE1NWQ3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUaHUsIDMwIEp1biAyMDIyIDE2OjIxOjU4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g dGVzdHN1aXRlOiB2ZXJpZnkgZGlyZWN0bHkgbWVyZ2VkIERXX0FUX2RlY2xhcmF0aW9ucwoK RG8gbm90IHJlbHkgb24gbnVtYmVyIG9mIERXX0FUX2RlY2xhcmF0aW9uIGFuZCBjaGVjayBz eW1ib2xzCmluc3RlYWQuCi0tLQogdGVzdHN1aXRlL2R3ei50ZXN0cy9vZHItc3RydWN0LW5z LnNoIHwgMTQgKysrKysrKysrLS0tLS0KIHRlc3RzdWl0ZS9kd3oudGVzdHMvb2RyLXN0cnVj dC5zaCAgICB8IDE0ICsrKysrKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rlc3RzdWl0ZS9kd3ou dGVzdHMvb2RyLXN0cnVjdC1ucy5zaCBiL3Rlc3RzdWl0ZS9kd3oudGVzdHMvb2RyLXN0cnVj dC1ucy5zaAppbmRleCA0ZmQwMGFmLi5jNmUwZjFkIDEwMDY0NAotLS0gYS90ZXN0c3VpdGUv ZHd6LnRlc3RzL29kci1zdHJ1Y3QtbnMuc2gKKysrIGIvdGVzdHN1aXRlL2R3ei50ZXN0cy9v ZHItc3RydWN0LW5zLnNoCkBAIC0yMSw3ICsyMSwxMCBAQCBmb3IgbmFtZSBpbiBtZW1iZXJf b25lIG1lbWJlcl90d28gbWVtYmVyX3RocmVlIG1lbWJlcl9mb3VyOyBkbwogCWVzYWMKIGRv bmUKIAotZGVjbF9jbnQ9JChyZWFkZWxmIC13aSAxIHwgZ3JlcCAtYyAiRFdfQVRfZGVjbGFy YXRpb24iIHx8IHRydWUpCisjIENoZWNrIHRoYXQgYmJiIGFuZCBjY2MgYXJlIHByZXNlbnQg YXMgRFdfQVRfZGVjbGFyYXRpb24KK3JlYWRlbGYgLXdpIDEgfCBncmVwIC0zIERXX0FUX2Rl Y2xhcmF0aW9uID4gZGVjbHMKK2dyZXAgYmJiIGRlY2xzID4vZGV2L251bGwKK2dyZXAgY2Nj IGRlY2xzID4vZGV2L251bGwKIAogJGV4ZWNzL2R3ei1mb3ItdGVzdCAtLW9kciAxCiAKQEAg LTM4LDggKzQxLDkgQEAgZm9yIG5hbWUgaW4gbWVtYmVyX29uZSBtZW1iZXJfdHdvIG1lbWJl cl90aHJlZSBtZW1iZXJfZm91cjsgZG8KIGRvbmUKIAogIyBXZSBleHBlY3QgdHdvIGRlY2xz IHRvIGJlIHJlbW92ZWQsIGZvciBiYmIgYW5kIGNjYy4KLWV4cGVjdGVkX2RlY2xfY250PSQo KCRkZWNsX2NudCAtIDIpKQotZGVjbF9jbnQ9JChyZWFkZWxmIC13aSAxIHwgZ3JlcCAtYyAi RFdfQVRfZGVjbGFyYXRpb24iIHx8IHRydWUpCi1bICRleHBlY3RlZF9kZWNsX2NudCAtZXEg JGRlY2xfY250IF0KK3JlYWRlbGYgLXdpIDEgfCBncmVwIC0zIERXX0FUX2RlY2xhcmF0aW9u ID4gZGVjbHMgfHwgdHJ1ZQogCi1ybSAtZiAxCitpZiBncmVwIGJiYiBkZWNscyA+L2Rldi9u dWxsIDsgdGhlbiBleGl0IDE7IGZpCitpZiBncmVwIGNjYyBkZWNscyA+L2Rldi9udWxsIDsg dGhlbiBleGl0IDI7IGZpCisKK3JtIC1mIDEgZGVjbHMKZGlmZiAtLWdpdCBhL3Rlc3RzdWl0 ZS9kd3oudGVzdHMvb2RyLXN0cnVjdC5zaCBiL3Rlc3RzdWl0ZS9kd3oudGVzdHMvb2RyLXN0 cnVjdC5zaAppbmRleCBkMGZkZGY5Li5jNjc5M2Y5IDEwMDY0NAotLS0gYS90ZXN0c3VpdGUv ZHd6LnRlc3RzL29kci1zdHJ1Y3Quc2gKKysrIGIvdGVzdHN1aXRlL2R3ei50ZXN0cy9vZHIt c3RydWN0LnNoCkBAIC0yMSw3ICsyMSwxMCBAQCBmb3IgbmFtZSBpbiBtZW1iZXJfb25lIG1l bWJlcl90d28gbWVtYmVyX3RocmVlIG1lbWJlcl9mb3VyOyBkbwogCWVzYWMKIGRvbmUKIAot ZGVjbF9jbnQ9JChyZWFkZWxmIC13aSAxIHwgZ3JlcCAtYyAiRFdfQVRfZGVjbGFyYXRpb24i IHx8IHRydWUpCisjIENoZWNrIHRoYXQgYmJiIGFuZCBjY2MgYXJlIHByZXNlbnQgYXMgRFdf QVRfZGVjbGFyYXRpb24KK3JlYWRlbGYgLXdpIDEgfCBncmVwIC0zIERXX0FUX2RlY2xhcmF0 aW9uID4gZGVjbHMKK2dyZXAgYmJiIGRlY2xzID4vZGV2L251bGwKK2dyZXAgY2NjIGRlY2xz ID4vZGV2L251bGwKIAogJGV4ZWNzL2R3ei1mb3ItdGVzdCAtLW9kciAxCiAKQEAgLTM4LDgg KzQxLDkgQEAgZm9yIG5hbWUgaW4gbWVtYmVyX29uZSBtZW1iZXJfdHdvIG1lbWJlcl90aHJl ZSBtZW1iZXJfZm91cjsgZG8KIGRvbmUKIAogIyBXZSBleHBlY3QgdHdvIGRlY2xzIHRvIGJl IHJlbW92ZWQsIGZvciBiYmIgYW5kIGNjYy4KLWV4cGVjdGVkX2RlY2xfY250PSQoKCRkZWNs X2NudCAtIDIpKQotZGVjbF9jbnQ9JChyZWFkZWxmIC13aSAxIHwgZ3JlcCAtYyAiRFdfQVRf ZGVjbGFyYXRpb24iIHx8IHRydWUpCi1bICRleHBlY3RlZF9kZWNsX2NudCAtZXEgJGRlY2xf Y250IF0KK3JlYWRlbGYgLXdpIDEgfCBncmVwIC0zIERXX0FUX2RlY2xhcmF0aW9uID4gZGVj bHMgfHwgdHJ1ZQogCi1ybSAtZiAxCitpZiBncmVwIGJiYiBkZWNscyA+L2Rldi9udWxsIDsg dGhlbiBleGl0IDE7IGZpCitpZiBncmVwIGNjYyBkZWNscyA+L2Rldi9udWxsIDsgdGhlbiBl eGl0IDI7IGZpCisKK3JtIC1mIDEgZGVjbHMKLS0gCjIuMzYuMQoK --------------NOmzMO0mKvshU51YtL1tRO57--