From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 39AD13950430 for ; Fri, 26 Feb 2021 11:59:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 39AD13950430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 51776AFFB; Fri, 26 Feb 2021 11:59:12 +0000 (UTC) Subject: Re: [PATCH][testsuite] Fix pr25109.sh on riscv64 To: Jakub Jelinek , Mark Wielaard Cc: dwz@sourceware.org References: <20210226101421.GA29849@delia> <20210226102831.GD3014@wildebeest.org> <20210226103545.GW4020736@tucnak> From: Tom de Vries Message-ID: Date: Fri, 26 Feb 2021 12:59:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226103545.GW4020736@tucnak> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: dwz@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Dwz mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 11:59:14 -0000 On 2/26/21 11:35 AM, Jakub Jelinek wrote: > On Fri, Feb 26, 2021 at 11:28:31AM +0100, Mark Wielaard wrote: >> On Fri, Feb 26, 2021 at 11:14:23AM +0100, Tom de Vries wrote: >>> On riscv64, I run into: >>> ... >>> cc main.c no-multifile-prop-dw.S -o no-multifile-prop >>> no-multifile-prop-dw.S: Assembler messages: >>> no-multifile-prop-dw.S:25: Error: non-constant .uleb128 is not supported >>> make: *** [Makefile:99: no-multifile-prop] Error 1 >>> ... >>> >>> Fix this by allowing to fail to build the test-case, and marking it as >>> unsupported. >>> >>> Any comments? >> >> If it doesn't even build then there is not much else we can do than >> skip it. So I would push this. >> >> But this is a little surprising. >> The construct seems like it is represented by a known constant at compile time: >> >> .uleb128 .Lexpr_end4 - .Lexpr_start3/* expression */ >> .Lexpr_start3: >> .byte 0xf2 /* DW_OP_GNU_implicit_pointer */ >> .4byte .Llabel2 >> .sleb128 0 >> .Lexpr_end4: >> >> There isn't anything between the two labels that can have a variable >> size. So it might be a good idea to file a bug report against >> binutils as for not allowing this on riscv64. > > I believe the riscv people explain it by aggressive linker optimizations > that make those not to work, but perhaps that applies to normal sections, > but don't see how can that apply to .debug* sections... > They shouldn't be doing any kind of aggressive linker relaxations on > .debug*. > I found an existing PR: https://sourceware.org/bugzilla/show_bug.cgi?id=27215 . Thanks, - Tom