Re: [PATCH] Always assign svalue when checking and reporting negative values

[Mark Wielaard <mark@klomp.org>]

Hi,

On Thu, 2022-06-30 at 14:42 +0200, Mark Wielaard wrote:
> GCC12 warns:
> 
> In file included from /usr/include/error.h:59,
>                  from dwz.c:23:
> In function ‘error’,
>     inlined from ‘checksum_die’ at dwz.c:3364:7:
> /usr/include/bits/error.h:42:5: warning: ‘svalue’ may be used
>    uninitialized [-Wmaybe-uninitialized]
>    42 |  __error_alias (__status, __errnum, __format, __va_arg_pack
> ());
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~
> dwz.c: In function ‘checksum_die’:
> dwz.c:3354:25: note: ‘svalue’ was declared here
>  3354 |                 int64_t svalue = read_sleb128 (ptr);
>       |                         ^~~~~~
> 
> It is correct. We jump to the common error reporting label negative
> where we expect svalue to be set so we can print it in the error
> message. But it isn't in all places. Fix this by explicitly assigning
> svalue first in all places we goto negative on failure.
> 
> 	* dwz.c (checksum_die): Always assign svalue when
> 	checking and reporting on unexpected negative values.

I pushed this one.

Cheers,

Mark