[Bug 1000987] USB Mass-storage driver (slave side)

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |john@dallaway.org.uk

--- Comment #3 from John Dallaway <john@dallaway.org.uk> 2010-10-18 17:00:29 BST ---
-------- Original Message --------
Subject: RE: USB mass storage package (slave side).
Date: Mon, 18 Oct 2010 07:13:42 -0700
From: Christophe Coutand <ccoutand@stmi.com>
To: John Dallaway <john@dallaway.org.uk>
CC: <ecos-patches@ecos.sourceware.org>,    "Chris Holgate <chris@zynaptic.com>,
   "Ilija Stanislevik" <ilijas@siva.com.mk>

Hi John,

Bugzilla report was previously created:

   http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

I will upload an updated patch.

Christophe

-----Original Message-----
From: John Dallaway [mailto:john@dallaway.org.uk] 
Sent: 18. oktober 2010 16:08
To: Christophe Coutand
Cc: ecos-patches@ecos.sourceware.org; Chris Holgate; Ilija Stanislevik
Subject: Re: USB mass storage package (slave side).

Hi Christophe

Christophe Coutand wrote:

> Calling USB endpoint with their devtab entry name ( .e.g. /dev/usbsX )
> was meant to be more user friendly but can be easily changed. I guess
> that is the meaning of the new USB API as well.

The new API is intended to provide more flexibility for modern USB slave
hardware (dynamic endpoint configuration).

> Note that the patch is missing a file for some reason
> ( usbs_msd_scsi.h ). I can generate a new patch, shall I remove the
> dependency towards the endpoint devtab entry?

If you have time to remove the dependency on endpoint devtab entries,
that would be great. Also, could you raise a new bugzilla report at
http://bugs.ecos.sourceware.org for your contribution? It's much easier
to track patches and the discussion about them in Bugzilla.

To be clear, the new USB API presented at:

  http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001024

is not yet formalised, but any future changes required to use the new
API should be independent of work to remove the dependency on endpoint
devtab entries within your MSD function driver package.

Thank you

John Dallaway
eCos maintainer

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #920 is|0                           |1
           obsolete|                            |

--- Comment #4 from Christophe Coutand <ecos@hotmail.co.uk> 2010-10-18 22:02:53 BST ---
Created an attachment (id=1003)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1003)
Source code patch

Hi John,

Updated patch as required.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
         AssignedTo|backlog@bugs.ecos.sourcewar |john@dallaway.org.uk
                   |e.org                       |
     Ever Confirmed|0                           |1

--- Comment #5 from John Dallaway <john@dallaway.org.uk> 2010-11-01 14:24:02 GMT ---
Created an attachment (id=1007)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1007)
usbs_msd-101101.patch

This experimental patch allows the mass storage device support to work with USB
drivers that use dynamic data endpoint configuration.

Christophe, I've been able to run up the usbs_test_ramdisk test on an
STM3210E-EVAL board with this patch. Two initial issues:

*  usbs_serial_wait_until_configured() should be renamed to
   usbs_msd_wait_until_configured()

*  The changes I have made to this function assume that the caller is
   waiting for MSD0. We could make this more generic by extending the
   usbs_msd struct to hold a "use dynamic data endpoints" boolean - or
   is there a better way?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1003|0                           |1
        is obsolete|                            |

--- Comment #6 from Christophe Coutand <ecos@hotmail.co.uk> 2010-11-02 18:53:48 GMT ---
Created an attachment (id=1008)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1008)
Source code patch - version 3

Hi John,

I have uploaded an updated patch including your changes. Tested ok on
AT91SAM7X256 board with static end-points.

Regards,
Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED

--- Comment #7 from John Dallaway <john@dallaway.org.uk> 2010-11-03 08:19:10 GMT ---
Thank you, Christophe. I will take a look...

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

--- Comment #8 from John Dallaway <john@dallaway.org.uk> 2010-11-12 11:46:27 GMT ---
Christophe, your latest patch works for me on STM3210E-EVAL. I will remove the
requirement for CYGPKG_FS_FAT in order to build the test since it will also
build without this package.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO

--- Comment #9 from John Dallaway <john@dallaway.org.uk> 2010-11-12 13:24:18 GMT ---
Christophe, I've checked in your latest code drop.

Thank you for another eCos contribution!

I note that the documentation SGML file was missing from your latest patch. Is
this because it now requires some revision?

If you would care to check the SGML and revise if necessary, I will add it to
the package.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

--- Comment #10 from Christophe Coutand <ecos@hotmail.co.uk> 2010-11-12 13:35:55 GMT ---
Hi John,

I think the documentation needs some updates after the changes made to the
source code. I will prepare an updated patch for the documentation.

Thanks,
Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

--- Comment #11 from Christophe Coutand <ecos@hotmail.co.uk> 2010-11-13 09:58:12 GMT ---
Created an attachment (id=1015)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1015)
package documentation

Updated package documentation.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

--- Comment #12 from Christophe Coutand <ecos@hotmail.co.uk> 2010-11-13 09:59:39 GMT ---
Created an attachment (id=1016)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1016)
Updated Changelog

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #13 from John Dallaway <john@dallaway.org.uk> 2010-11-13 12:00:02 GMT ---
Documentation now checked-in. Thank you.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
         AssignedTo|backlog@bugs.ecos.sourcewar |john@dallaway.org.uk
                   |e.org                       |
     Ever Confirmed|0                           |1

--- Comment #5 from John Dallaway <john@dallaway.org.uk> 2010-11-01 14:24:02 GMT ---
Created an attachment (id=1007)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1007)
usbs_msd-101101.patch

This experimental patch allows the mass storage device support to work with USB
drivers that use dynamic data endpoint configuration.

Christophe, I've been able to run up the usbs_test_ramdisk test on an
STM3210E-EVAL board with this patch. Two initial issues:

*  usbs_serial_wait_until_configured() should be renamed to
   usbs_msd_wait_until_configured()

*  The changes I have made to this function assume that the caller is
   waiting for MSD0. We could make this more generic by extending the
   usbs_msd struct to hold a "use dynamic data endpoints" boolean - or
   is there a better way?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #920 is|0                           |1
           obsolete|                            |

--- Comment #4 from Christophe Coutand <ecos@hotmail.co.uk> 2010-10-18 22:02:53 BST ---
Created an attachment (id=1003)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1003)
Source code patch

Hi John,

Updated patch as required.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1000987] USB Mass-storage driver (slave side)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |john@dallaway.org.uk

--- Comment #3 from John Dallaway <john@dallaway.org.uk> 2010-10-18 17:00:29 BST ---
-------- Original Message --------
Subject: RE: USB mass storage package (slave side).
Date: Mon, 18 Oct 2010 07:13:42 -0700
From: Christophe Coutand <ccoutand@stmi.com>
To: John Dallaway <john@dallaway.org.uk>
CC: <ecos-patches@ecos.sourceware.org>,    "Chris Holgate <chris@zynaptic.com>,
   "Ilija Stanislevik" <ilijas@siva.com.mk>

Hi John,

Bugzilla report was previously created:

   http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000987

I will upload an updated patch.

Christophe

-----Original Message-----
From: John Dallaway [mailto:john@dallaway.org.uk] 
Sent: 18. oktober 2010 16:08
To: Christophe Coutand
Cc: ecos-patches@ecos.sourceware.org; Chris Holgate; Ilija Stanislevik
Subject: Re: USB mass storage package (slave side).

Hi Christophe

Christophe Coutand wrote:

> Calling USB endpoint with their devtab entry name ( .e.g. /dev/usbsX )
> was meant to be more user friendly but can be easily changed. I guess
> that is the meaning of the new USB API as well.

The new API is intended to provide more flexibility for modern USB slave
hardware (dynamic endpoint configuration).

> Note that the patch is missing a file for some reason
> ( usbs_msd_scsi.h ). I can generate a new patch, shall I remove the
> dependency towards the endpoint devtab entry?

If you have time to remove the dependency on endpoint devtab entries,
that would be great. Also, could you raise a new bugzilla report at
http://bugs.ecos.sourceware.org for your contribution? It's much easier
to track patches and the discussion about them in Bugzilla.

To be clear, the new USB API presented at:

  http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001024

is not yet formalised, but any future changes required to use the new
API should be independent of work to remove the dependency on endpoint
devtab entries within your MSD function driver package.

Thank you

John Dallaway
eCos maintainer

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.