[Bug 1001073] New: ROM FS do not allow to use FIS names as device name in mount.

[Bug 1001073] New: ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

           Summary: ROM FS do not allow to use FIS names as device name in
                    mount.
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: ROM filesystem
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: aaganichev@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


The most samples show that this behaviour is valid for JFFS2, but ROM FS only
allows to specify exact address as device name which is ugly. The patch
attached allows to mount ROM FS image as follows:

mount("/dev/flash/fis/romfs", "/rom", "romfs");

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

--- Comment #1 from Alexander Aganichev <aaganichev@gmail.com> 2010-11-11 11:30:04 GMT ---
Created an attachment (id=1013)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1013)
Proposed solution

It looks like I forgot to attach file.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org, john@dallaway.org.uk
          Component|ROM filesystem              |Patches and contributions

--- Comment #2 from John Dallaway <john@dallaway.org.uk> 2010-11-11 14:52:55 GMT ---
Alexander, thank you for making a contribution.

Being able to reference a ROM filesystem via a FIS entry seems like a good idea
since this is a typical usage scenario and the feature would improve usability.
However, one could also argue that this is application-level glue and does not
belong in the ROM filesystem package.

Any comments from other maintainers?

If there is some consensus that the feature is desirable, the lookup should be
made conditional on a new CYGFUN_FS_ROM_FLASH_BLOCK_DEVICE_LOOKUP option which
"requires CYGPKG_IO_FLASH_BLOCK_DEVICE" to avoid forcing a dependency on
CYGPKG_IO_FLASH.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #3 from Jonathan Larmour <jifl@ecoscentric.com> 2010-11-11 16:06:50 GMT ---
I agree with John. Yes it should be optional, and due to the requirement should
 default to off.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
         AssignedTo|unassigned@bugs.ecos.source |john@dallaway.org.uk
                   |ware.org                    |
     Ever Confirmed|0                           |1

--- Comment #4 from John Dallaway <john@dallaway.org.uk> 2010-11-13 09:28:00 GMT ---
Alexander, could you wrap your changes in:

  #if defined(CYGFUN_FS_ROM_FLASH_BLOCK_DEVICE_LOOKUP)
  #endif

add the following CDL option to romfs.cdl:

  cdl_option CYGFUN_FS_ROM_FLASH_BLOCK_DEVICE_LOOKUP {
    display "Lookup flash block device names"
    flavor bool
    requires CYGPKG_IO_FLASH
    requires CYGPKG_IO_FLASH_BLOCK_DEVICE
    default_value 0
    description "Enables the location of a ROM filesystem to
      be specified using a flash block device name such as
      \"/dev/flash/fis/romfs\" in the call to mount()."
  }

and resubmit your patch please?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001073] New: ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

           Summary: ROM FS do not allow to use FIS names as device name in
                    mount.
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: ROM filesystem
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: aaganichev@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


The most samples show that this behaviour is valid for JFFS2, but ROM FS only
allows to specify exact address as device name which is ugly. The patch
attached allows to mount ROM FS image as follows:

mount("/dev/flash/fis/romfs", "/rom", "romfs");

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

--- Comment #1 from Alexander Aganichev <aaganichev@gmail.com> 2010-11-11 11:30:04 GMT ---
Created an attachment (id=1013)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1013)
Proposed solution

It looks like I forgot to attach file.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org, john@dallaway.org.uk
          Component|ROM filesystem              |Patches and contributions

--- Comment #2 from John Dallaway <john@dallaway.org.uk> 2010-11-11 14:52:55 GMT ---
Alexander, thank you for making a contribution.

Being able to reference a ROM filesystem via a FIS entry seems like a good idea
since this is a typical usage scenario and the feature would improve usability.
However, one could also argue that this is application-level glue and does not
belong in the ROM filesystem package.

Any comments from other maintainers?

If there is some consensus that the feature is desirable, the lookup should be
made conditional on a new CYGFUN_FS_ROM_FLASH_BLOCK_DEVICE_LOOKUP option which
"requires CYGPKG_IO_FLASH_BLOCK_DEVICE" to avoid forcing a dependency on
CYGPKG_IO_FLASH.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #3 from Jonathan Larmour <jifl@ecoscentric.com> 2010-11-11 16:06:50 GMT ---
I agree with John. Yes it should be optional, and due to the requirement should
 default to off.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
         AssignedTo|unassigned@bugs.ecos.source |john@dallaway.org.uk
                   |ware.org                    |
     Ever Confirmed|0                           |1

--- Comment #4 from John Dallaway <john@dallaway.org.uk> 2010-11-13 09:28:00 GMT ---
Alexander, could you wrap your changes in:

  #if defined(CYGFUN_FS_ROM_FLASH_BLOCK_DEVICE_LOOKUP)
  #endif

add the following CDL option to romfs.cdl:

  cdl_option CYGFUN_FS_ROM_FLASH_BLOCK_DEVICE_LOOKUP {
    display "Lookup flash block device names"
    flavor bool
    requires CYGPKG_IO_FLASH
    requires CYGPKG_IO_FLASH_BLOCK_DEVICE
    default_value 0
    description "Enables the location of a ROM filesystem to
      be specified using a flash block device name such as
      \"/dev/flash/fis/romfs\" in the call to mount()."
  }

and resubmit your patch please?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

Alexander Aganichev <aaganichev@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1013|0                           |1
        is obsolete|                            |

--- Comment #5 from Alexander Aganichev <aaganichev@gmail.com> 2010-11-13 10:49:08 GMT ---
Created an attachment (id=1017)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1017)
Updated patch with John's proposal

John, thanks for CDL code. I incorporated it in the patch and wrapped my code
with #ifdef's.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED

--- Comment #6 from John Dallaway <john@dallaway.org.uk> 2010-11-23 10:33:02 GMT ---
Alexander, thank you for the update. I'll take a look...

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1017|0                           |1
        is obsolete|                            |

--- Comment #7 from John Dallaway <john@dallaway.org.uk> 2010-11-29 16:19:52 GMT ---
Created an attachment (id=1031)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1031)
romfs-101129.patch

Final patch with comments/ChangeLog modified to indicate any flash block device
name should be usable + mk_romfs build for win32.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001073] ROM FS do not allow to use FIS names as device name in mount.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001073

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #8 from John Dallaway <john@dallaway.org.uk> 2010-11-29 16:31:05 GMT ---
Checked-in. Thank you for the contribution.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.