From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28475 invoked by alias); 22 Nov 2010 09:35:17 -0000 Received: (qmail 28439 invoked by uid 22791); 22 Nov 2010 09:35:16 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Nov 2010 09:35:12 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 70F502F78006 for ; Mon, 22 Nov 2010 09:35:10 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 61+IPWZeC2sH; Mon, 22 Nov 2010 09:35:06 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1001068] Bug in serial driver when using Parity (Even or Odd) X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Serial X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: john@dallaway.org.uk X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: john@dallaway.org.uk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC AssignedTo Ever Confirmed In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 22 Nov 2010 09:43:00 -0000 Message-Id: <20101122093500.8F8E32F78008@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2010/txt/msg00191.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001068 John Dallaway changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEEDINFO CC| |john@dallaway.org.uk AssignedTo|unassigned@bugs.ecos.source |john@dallaway.org.uk |ware.org | Ever Confirmed|0 |1 --- Comment #1 from John Dallaway 2010-11-22 09:34:58 GMT --- Phil, thank you for the bug report. Your proposed fix does not accommodate the STM32 7 data bits + parity bit mode (where the M bit should be clear). In effect, STM32 requires the word length to be specified inclusive of the parity bit. Since the word length is represented by a single bit only, I suggest we abandon the select_word_length array and calculate word_length in stm32_serial_config_port() as follows: cyg_uint32 word_length = ((new_config->word_length == CYGNUM_SERIAL_WORD_LENGTH_8) && (new_config->parity != CYGNUM_SERIAL_PARITY_NONE)) ? CYGHWR_HAL_STM32_UART_CR1_M_9 : CYGHWR_HAL_STM32_UART_CR1_M_8; Do you concur? -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.