From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28050 invoked by alias); 7 Jan 2011 14:36:04 -0000 Received: (qmail 28017 invoked by uid 22791); 7 Jan 2011 14:36:03 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Jan 2011 14:35:59 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id AB9972F78007 for ; Fri, 7 Jan 2011 14:35:56 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QI3QM577BB2t; Fri, 7 Jan 2011 14:35:56 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1001111] Access to saved registers from Cortex-M ISR X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: HAL X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: john@dallaway.org.uk X-Bugzilla-Status: NEW X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 07 Jan 2011 14:36:00 -0000 Message-Id: <20110107143553.DFFCC2F7800B@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2011/txt/msg00016.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001111 --- Comment #2 from John Dallaway 2011-01-07 14:35:52 GMT --- Nick, thanks for your comments. (In reply to comment #1) > The intention with the code as it was written is that if anything needs access > to the interrupt state then it should enable the existing code that saves a > full and complete CPU state and stores it in hal_saved_interrupt_state; either > by defining the CTRLC support option or by new means. Interested code can then > fetch it from there. That way this code is only included when this > functionality is required. I looked at hal_saved_interrupt_state, but it is declared only when the GDB break/Ctrl-C support is enabled. So... > The extra ISR argument is also a bad idea, it has > caused problems in other architectures and my intention was to keep the > Cortex-M architecture clean and not have it. > > There is maybe a case for defining a CDL option that controls this piece of > code and have that depend on CTRLC and BREAK support, as well as allowing it > to be enabled by any other package. I would like to propose a CYGINT_HAL_COMMON_SAVED_INTERRUPT_STATE_REQUIRED CDL interface which controls the declaration of 'hal_saved_interrupt_state'. The interface would be implemented by all of the following: * CYGDBG_HAL_DEBUG_GDB_BREAK_SUPPORT * CYGDBG_HAL_DEBUG_GDB_CTRLC_SUPPORT * profiling CDL options within those HALs which make use of 'hal_saved_interrupt_state' for profiling Individual architecture HALs could then test for CYGINT_HAL_COMMON_SAVED_INTERRUPT_STATE_REQUIRED > 0 to determine if it is necessary to assign a value to 'hal_saved_interrupt_state'. Other than the common HAL package, HAL packages would only require modification if/when the use of 'hal_saved_interrupt_state' outside the context of GDB Ctrl-C/break becomes necessary. The advantage of a CDL interface over a CDL option in this context is that the saved interrupt state support is automatically disabled when no-longer required. eg When profiling was being used but is now disabled. Again, any comments are welcome. I'll pick this up again next week. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.