From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18384 invoked by alias); 26 Mar 2011 04:21:02 -0000 Received: (qmail 18369 invoked by uid 22791); 26 Mar 2011 04:21:01 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Mar 2011 04:20:57 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 2F4882F7800A for ; Sat, 26 Mar 2011 04:20:56 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UXkGLI9aknic; Sat, 26 Mar 2011 04:20:54 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1001177] Redboot DHCP client race condition, XID, and retry problems. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: RedBoot X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: grant.b.edwards@gmail.com X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sat, 26 Mar 2011 04:21:00 -0000 Message-Id: <20110326042054.A83A92F78001@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2011/txt/msg00693.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001177 --- Comment #8 from Grant Edwards 2011-03-26 04:20:52 GMT --- (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #2) > > > > > - It would be nice (although admittedly arguably an enhancement) > > > for all of bootp/dhcp support to be removable by config > > > option. There are many instances where redboot is only ever > > > given a static IP, so this code is just taking up space. > > > > I've create a new CYGPKG_REDBOOT_NETWORKING_BOOTP which now contains > > CYGSEM_REDBOOT_NETWORKING_DHCP and CYGSEM_REDBOOT_NETWORKING_VERBOSE_BOOTP. > > > > I'm wondering about the latter names. Are names supposed to > > reflect package heirachy like more like this? > > > > CYGPKG_REDBOOT_NETWORKING > > CYGPKG_REDBOOT_NETWORKING_BOOTP > > CYGPKG_REDBOOT_NETWORKING_BOOTP_DHCP > > CYGPKG_REDBOOT_NETWORKING_BOOTP_VERBOSE > > While I think that would be the ideal, changing option names (in > general invalidates people's existing configurations, so shouldn't > be done lightly. Agreed. It had slipped my mind that two of the names were for options that already existed -- and enhancing the consistency of the names a bit doesn't justify breaking somebody's previously working configuration. > I'd suggest just leaving it. The more important thing is that the > actual hierarchy of options is correct. But if you want to change > it, I'm ok with that too. The two existing names are going to stay the same. >[...] > > I don't have a strong opinion one way or the other, but if I were to > > pick, I'd move CYGSEM_REDBOOT_DEFAULT_NO_BOOTP into > > CYGPKG_REDBOOT_NETWORKING_BOOTP and make it independent of whether > > CYGDAT_REDBOOT_DEFAULT_IP_ADDR is set or not. Who are we to say that > > no default IP address and bootp built but disabled by default isn't > > useful to somebody? > > Yes, there seems no reason to prohibit that, so if you didn't mind, > I think it would be good if you could do that. Done. -- Grant -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.