From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20689 invoked by alias); 5 Jul 2011 17:25:47 -0000 Received: (qmail 20662 invoked by uid 22791); 5 Jul 2011 17:25:46 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jul 2011 17:25:32 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 013592F7800C for ; Tue, 5 Jul 2011 18:25:32 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bdBlKgyvH4ue; Tue, 5 Jul 2011 18:25:30 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1001253] Kernel tests on small memory targets X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Other X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 05 Jul 2011 17:25:00 -0000 Message-Id: <20110705172529.0A7E12F7800D@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2011/txt/msg01023.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001253 --- Comment #23 from Ilija Kocho 2011-07-05 18:25:26 BST --- (In reply to comment #22) > (In reply to comment #20) > > > To me both are obvious. I think it is not necessary explaining max to eCos > > programmer :) > > > > > #ifndef max > > > #define max(X,Y) ((X) > (Y) ? (X) : (Y)) > > > #endif > > No, this is not explanation :-) This is a *reminder* that such a check and > definition should be *above* its usage. FYI: there is the same definition > for min() in the test. > I meant complete max() definition. Kind of explains what #define NTEST_THREADS \ (__NTEST_THREADS >= NTEST_2_THR ? __NTEST_THREADS : NTEST_2_THR) does. > Then I did correct myself (comment 18) and offer N_THREADS_AVAIL for > naming. Yeah, i saw it but too late, sorry. > > > > NTEST_2_THR was intended to mean constant 2. If you don't like it we > > can keep the original (bare 2). > > As for me "bare 2" is preferred there. Set. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.