public inbox for ecos-bugs@sourceware.org help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP Date: Tue, 23 Aug 2011 20:47:00 -0000 [thread overview] Message-ID: <20110823204657.624542F7800B@mail.ecoscentric.com> (raw) In-Reply-To: <bug-1001275-777@http.bugs.ecos.sourceware.org/> Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275 --- Comment #25 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-23 21:46:54 BST --- (In reply to comment #24) [snip] > > cortexm_regs.h: > > > > Ilija, I missed that you have used such an order for arguments in REV > > macros, for example > > > > +// Reverse word > > +#define CYGARC_REV(_swapped_,_original_) \ > > + __asm__ volatile ("rev %0, %1\n" : "=r"(_swapped_) : "r"(_original_)) > > + > > > > It looks clear for ARM assembler gurus (dst <- src), and for C-guys > > it looks a bit puzzled, (IMO) they are accustomed to same [snip] > I would insist to keep present order. Here are some arguments: > > These macros shall be used mainly by people who are familiar with > assembler and they would be surprised if order is not as in assembler. > > Also there is a long tradition the destination to be first argument in > C functions. The origins date back to big-bang, look for rationale in > K&R book. Examples strcpy(), strcat(), memcpy()... > Ilija, thank you for your comments. I have to agree with such arguments :-) > > Still, I would use prototypes where result returns in the second > > argument. And if you have no objections I would use multiline > > variants for those macros. > > > > #define CYGARC_REV( _origin_, _swapped_ ) \ > > asm volatile( "rev %0, %1\n" \ > > : "=r" (_swapped_) \ > > : "r" (_origin_) \ > > ); > > I wouldn't object, only I don't see the need for it. Present layout > doesn't stretch out of limits. As far as I have seen other > architectures (coldfire, ppc) use same layout. I see. It seems it's a matter of taste, as for me I try to avoid the 1-liners near to 78th position. So, I plan to check-in the sent patches with some minor clean-ups, of course, if no one else has objections. Sergei -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
next prev parent reply other threads:[~2011-08-23 20:47 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-03 17:46 [Bug 1001275] New: Cortex-M (armV7) architecture endian instructions / lwIP bugzilla-daemon 2011-07-03 17:52 ` [Bug 1001275] " bugzilla-daemon 2011-07-03 17:56 ` [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP bugzilla-daemon 2011-08-15 20:18 ` bugzilla-daemon 2011-08-17 20:26 ` bugzilla-daemon 2011-08-18 21:14 ` bugzilla-daemon 2011-08-19 8:41 ` bugzilla-daemon 2011-08-19 15:10 ` bugzilla-daemon 2011-08-19 15:18 ` bugzilla-daemon 2011-08-21 13:46 ` bugzilla-daemon 2011-08-22 12:10 ` bugzilla-daemon 2011-08-22 13:01 ` bugzilla-daemon 2011-08-22 13:23 ` bugzilla-daemon 2011-08-22 13:36 ` bugzilla-daemon 2011-08-22 14:24 ` bugzilla-daemon 2011-08-22 18:26 ` bugzilla-daemon 2011-08-23 13:32 ` bugzilla-daemon 2011-08-23 14:18 ` bugzilla-daemon 2011-08-23 16:14 ` bugzilla-daemon 2011-08-23 16:17 ` bugzilla-daemon 2011-08-23 16:19 ` bugzilla-daemon 2011-08-23 16:21 ` bugzilla-daemon 2011-08-23 19:28 ` bugzilla-daemon 2011-08-23 20:15 ` bugzilla-daemon 2011-08-23 20:47 ` bugzilla-daemon [this message] 2011-08-24 6:51 ` bugzilla-daemon 2011-08-24 7:08 ` bugzilla-daemon 2011-08-24 13:34 ` bugzilla-daemon 2011-08-24 13:47 ` bugzilla-daemon 2011-08-24 16:43 ` bugzilla-daemon 2011-08-24 17:01 ` bugzilla-daemon 2011-08-24 17:56 ` bugzilla-daemon 2011-08-25 8:02 ` bugzilla-daemon 2011-08-25 8:20 ` bugzilla-daemon 2011-08-25 14:03 ` bugzilla-daemon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110823204657.624542F7800B@mail.ecoscentric.com \ --to=bugzilla-daemon@bugs.ecos.sourceware.org \ --cc=unassigned@bugs.ecos.sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).