From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ecos-bugs-return-8306-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 30082 invoked by alias); 2 Oct 2011 15:45:58 -0000
Received: (qmail 30059 invoked by uid 22791); 2 Oct 2011 15:45:56 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0
	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 Oct 2011 15:45:37 +0000
Received: by mail.ecoscentric.com (Postfix, from userid 48)
	id A7FC02F78008; Sun,  2 Oct 2011 16:45:36 +0100 (BST)
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config()
 for stm32 spi driver
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCos
X-Bugzilla-Component: Patches and contributions
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sergei.gavrikov@gmail.com
X-Bugzilla-Status: NEEDINFO
X-Bugzilla-Priority: low
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: 
In-Reply-To: <bug-1001351-777@http.bugs.ecos.sourceware.org/>
References: <bug-1001351-777@http.bugs.ecos.sourceware.org/>
X-Bugzilla-URL: http://bugs.ecos.sourceware.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Sun, 02 Oct 2011 15:45:00 -0000
Message-Id: <20111002154534.21B042F78008@mail.ecoscentric.com>
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
X-SW-Source: 2011/txt/msg01216.txt.bz2

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-02 16:45:31 BST ---
The patch looks good enough to commit. However, I would change CL
record, i.e. write something like:

  Add support for CYG_IO_{GET,SET}_CONFIG_SPI_CLOCKRATE.

IMO, "Non-dummy" looks excessively there.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.