From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26046 invoked by alias); 8 Oct 2011 14:27:50 -0000 Received: (qmail 26035 invoked by uid 22791); 8 Oct 2011 14:27:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 08 Oct 2011 14:27:37 +0000 Received: by mail.ecoscentric.com (Postfix, from userid 48) id 0D4182F7800A; Sat, 8 Oct 2011 15:27:36 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board. X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sat, 08 Oct 2011 14:27:00 -0000 Message-Id: <20111008142727.17D1A2F78008@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2011/txt/msg01235.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219 --- Comment #4 from Ilija Kocho 2011-10-08 15:27:25 BST --- (In reply to comment #3) > Hi Jerzy > > Thank you for your contribution. Here are my first remarks: > > 1. Some unresolved conflicts remain upon Propox board selection in Configtool > and it may mislead the user that something is broken. It seems that Configtool > can't resolve the CYGHWR_HAL_CORTEXM_STM32_CLOCK_PLL_SOURCE on it's own so > let's make it little-bit easier: > - Is it possible to re-arrange legal_values expression in order to make it > easier for Configtool? > - Or it is better to calculate default_value conditionally > (CYGINT_HAL_CORTEXM_STM32_CL==0 ?) > > 2. CYGPKG_IO_ETH_DRIVERS is normally not included in the target. Not everybody > would use Ethernet. Please remove it. > > 3. FYI, the PHY driver DP8348 has been resolved in meantime by Bug 1001235. > Please synchronize your code with it. 4. Just one more thing: Won't it be better if Propox on-board chip member appears (CYGHWR_HAL_CORTEXM_STM32) once this board is selected? > > Now some general hints: It usually takes a number of iterations before code is > fit for commit and it would be easier for me (hopefully also for you) if you > break the patch in several diffs (divide and conquer). Ideally - a diff for > every affected package, in this case: /eth driver/, /variant/, /platform/ and > eventually /phy driver/. As exception ecos.db is better not sent as diff, > instead put your ecos.db entries in a plain file and name it ecos_db.txt . -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.