public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
Date: Sat, 03 Dec 2011 20:01:00 -0000	[thread overview]
Message-ID: <20111203200133.89D1C2F78003@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001359-777@http.bugs.ecos.sourceware.org/>

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359

--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-12-03 20:01:30 GMT ---
(In reply to comment #1)
> If the ucd-snmp/mibgroup/util_funcs.h is included by an external code
> it includes a file from an invalid location. The same is true for
> config.h.
> 
> See attach for a fix that is enough for my usage - I don't guarantee
> that it covers all of the cases.

Hi Stano,

Thank you for your report.

The ``config.h'' is not part of UCD-SNMP API headers, so, we can fix
that header as you suggested. But, to fix ``util_funcs.h'' is an issue.

As I could see (I tested original ucd-snmp-4.1.2 installation and the
latest ucd-snmp-4.2.7.1 package from net-snmp) normal ucd-snmp install
process does propagate two internal mibgroup's headers (struct.h and
util_funcs.h) under <prefix>/include/ucd-snmp directory. Thus, those
internal headers become the API headers.

Unfortunately, we have not the same headers under eCos <PREFIX>. The
eCos UCD-SNMP header files are all the UCD-SNMP's header files including
internal headers (not only API headers) and their subdirs. I think that
was KIS(s) principle as CDL command ``include_files'' does not let us to
change a structure of the package's headers under eCos <PREFIX>/include.

I think that we have to get all UCD-SNMP API headers in a right place,
i.e.  under <PREFIX>/include/ucd-snmp directory and I think we would use
CDL ``make'' command in snmpagent.cdl to copy absent headers there

 make -priority=1 {
  <PREFIX>/include/ucd-snmp/struct.h : <PACKAGE>/include/mibgroup/struct.h
  mkdir -p $(dir $@)
  cp -f $^ $(dir $@)
 }

and the same command for ``util_funcs.h'' header. Well, it's mine and
may be some one has either another view on your fix or yet another (own)
solution in CDL (I tested above).

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


  parent reply	other threads:[~2011-12-03 20:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon [this message]
2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
  -- strict thread matches above, loose matches on Subject: below --
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111203200133.89D1C2F78003@mail.ecoscentric.com \
    --to=bugzilla-daemon@bugs.ecos.sourceware.org \
    --cc=unassigned@bugs.ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).