public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug 1001474] New: io/serial/common/serial.c: overrun condition returns uninitialized .stat item
@ 2012-02-07 8:48 bugzilla-daemon
2012-02-07 9:08 ` [Bug 1001474] " bugzilla-daemon
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla-daemon @ 2012-02-07 8:48 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001474
Summary: io/serial/common/serial.c: overrun condition returns
uninitialized .stat item
Product: eCos
Version: CVS
Platform: All
OS/Version: Other
Status: UNCONFIRMED
Severity: minor
Priority: low
Component: Serial
AssignedTo: unassigned@bugs.ecos.sourceware.org
ReportedBy: bernard.fouche@kuantic.com
CC: ecos-bugs@ecos.sourceware.org
Class: Advice Request
Created an attachment (id=1550)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1550)
set cyg_serial_line_status_t.stat to zero when overrun detected
If an overrun is detected, serial_indicate_status() is called with a pointer to
a cyg_serial_line_status_t structure, the 'which' item of this structure is set
to 'CYGNUM_SERIAL_STATUS_OVERRUNERR', but the 'stat' item is left
uninitialized. The proposed patch forces the 'stat' item to zero since the
generic serial driver sets 'stat' to 1 for overrun: using different values
helps distinguish the origin of the overrun problem.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug 1001474] io/serial/common/serial.c: overrun condition returns uninitialized .stat item
2012-02-07 8:48 [Bug 1001474] New: io/serial/common/serial.c: overrun condition returns uninitialized .stat item bugzilla-daemon
@ 2012-02-07 9:08 ` bugzilla-daemon
0 siblings, 0 replies; 2+ messages in thread
From: bugzilla-daemon @ 2012-02-07 9:08 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001474
Bernard Fouché <bernard.fouche@kuantic.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1550|0 |1
is obsolete| |
--- Comment #1 from Bernard Fouché <bernard.fouche@kuantic.com> 2012-02-07 09:07:50 GMT ---
Created an attachment (id=1551)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1551)
sets stat.value to zero when overrun detected
typo in ChangeLog
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
>From ecos-bugs-return-8774-listarch-ecos-bugs=sources.redhat.com@sourceware.org Tue Feb 07 09:08:12 2012
Return-Path: <ecos-bugs-return-8774-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-ecos-bugs@sources.redhat.com
Received: (qmail 7076 invoked by alias); 7 Feb 2012 09:08:11 -0000
Received: (qmail 7057 invoked by uid 22791); 7 Feb 2012 09:08:11 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0
tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Feb 2012 09:07:57 +0000
Received: by mail.ecoscentric.com (Postfix, from userid 48)
id DC6A52F78006; Tue, 7 Feb 2012 09:07:56 +0000 (GMT)
X-Original-To: unassigned@bugs.ecos.sourceware.org
Delivered-To: unassigned@bugs.ecos.sourceware.org
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001474] io/serial/common/serial.c: overrun condition returns
uninitialized .stat item
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCos
X-Bugzilla-Component: Serial
X-Bugzilla-Keywords:
X-Bugzilla-Severity: minor
X-Bugzilla-Who: bernard.fouche@kuantic.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: low
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Attachment #1550 is obsolete
In-Reply-To: <bug-1001474-777@http.bugs.ecos.sourceware.org/>
References: <bug-1001474-777@http.bugs.ecos.sourceware.org/>
X-Bugzilla-URL: http://bugs.ecos.sourceware.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Date: Tue, 07 Feb 2012 09:08:00 -0000
Message-Id: <20120207090751.7588E2F78006@mail.ecoscentric.com>
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
Delivered-To: mailing list ecos-bugs@sourceware.org
X-SW-Source: 2012/txt/msg00203.txt.bz2
Content-length: 855
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001474
Bernard Fouché <bernard.fouche@kuantic.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1550|0 |1
is obsolete| |
--- Comment #1 from Bernard Fouché <bernard.fouche@kuantic.com> 2012-02-07 09:07:50 GMT ---
Created an attachment (id=1551)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1551)
sets stat.value to zero when overrun detected
typo in ChangeLog
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
>From ecos-bugs-return-8775-listarch-ecos-bugs=sources.redhat.com@sourceware.org Tue Feb 07 10:17:20 2012
Return-Path: <ecos-bugs-return-8775-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-ecos-bugs@sources.redhat.com
Received: (qmail 10938 invoked by alias); 7 Feb 2012 10:17:17 -0000
Received: (qmail 10930 invoked by uid 22791); 7 Feb 2012 10:17:16 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0
tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Feb 2012 10:17:03 +0000
Received: from localhost (hagrid.ecoscentric.com [127.0.0.1])
by mail.ecoscentric.com (Postfix) with ESMTP id 2EC152F7800A
for <ecos-bugs@ecos.sourceware.org>; Tue, 7 Feb 2012 10:17:02 +0000 (GMT)
Received: from mail.ecoscentric.com ([127.0.0.1])
by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id PT-uPOCMpyPY; Tue, 7 Feb 2012 10:16:55 +0000 (GMT)
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-bugs@ecos.sourceware.org
Subject: [Bug 1001475] New: Generic 16x5x driver do not clear overrun error
at boot
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCos
X-Bugzilla-Component: Serial
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bernard.fouche@kuantic.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: low
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-1001475-13@http.bugs.ecos.sourceware.org/>
X-Bugzilla-URL: http://bugs.ecos.sourceware.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Tue, 07 Feb 2012 10:17:00 -0000
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
Delivered-To: mailing list ecos-bugs@sourceware.org
X-SW-Source: 2012/txt/msg00204.txt.bz2
Content-length: 1938
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id\x1001475
Summary: Generic 16x5x driver do not clear overrun error at
boot
Product: eCos
Version: CVS
Platform: All
OS/Version: Other
Status: UNCONFIRMED
Severity: normal
Priority: low
Component: Serial
AssignedTo: unassigned@bugs.ecos.sourceware.org
ReportedBy: bernard.fouche@kuantic.com
CC: ecos-bugs@ecos.sourceware.org
Class: Advice Request
Created an attachment (id\x1552)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id\x1552)
always read a byte when clearing FIFO
(Original problem and fix proposal were made incorrectly in bug #1001392.)
When the driver runs its config_port() routine the first time, it clears the
FIFOs. However it does not clear the Overrun Error situation.
The side effect is, if an overrun condition exists prior to running
config_port(), the driver will loop forever in the DSR: the DSR code, when
considering RxTO, reads RHR only if there is at least a byte reported in the
FIFO.
But config_port() cleared the FIFO, so no byte is available there, so there is
no read from RHR, the overrun error condition continues, DSR loops forever at
boot time and the system is stuck.
Typical use case:
- a data logger always producing information is connected on a serial port.
- the system is being debugged with OpenOCD, and 'soft_reset_halt' is used:
there is no hardware reset done, so the serial controller always runs, even if
config_port() wasn't fired yet.
The patch is more than minimal, it can't break anything and it handles this
weird error case.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-07 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-07 8:48 [Bug 1001474] New: io/serial/common/serial.c: overrun condition returns uninitialized .stat item bugzilla-daemon
2012-02-07 9:08 ` [Bug 1001474] " bugzilla-daemon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).