[Bug 1001501] New: Fix warnings about type-punned pointers in bsd_tcpip code.

[Bug 1001501] New: Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

           Summary: Fix warnings about type-punned pointers in bsd_tcpip
                    code.
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: low
         Component: TCP/IP
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: grant.b.edwards@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1601)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1601)
Patch that modifies CFLAGS to fix compiler warnings about type-punned pointers.

Using newer versions of gcc (4.6) results in a lot of warnings about
dereferencing type-punned pointers in bsd_tcpip code (in ipv6
support).  Adding the -fno-strict-aliasing to CFLAGS fixes those
warnings.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

--- Comment #1 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-01 15:01:17 GMT ---
If the warnings are all in ipv6 code, should CFLAGS only contain the
new flag if ipv6 code is enabled?  I'm inclined to leave CFLAGS the
same for both cases just to keep things consistent.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-03 04:44:27 GMT ---
Reluctantly, simply due to the overwhelming number of warnings, I agree this
patch should go in. I guess we'll just have to think about updating the BSD
stack port at some point, if someone's got a free month or three.

Remember the extra ChangeLog newline though :-).

I think this is an exception to the rule that we should try and fix strict
aliasing problems. For example RedBoot has a bunch, and -fno-strict-aliasing
isn't appropriate there because it's our code, and it won't be fixed by a
future import from an upstream source.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

--- Comment #3 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-05 20:33:39 GMT ---
I've commited this change -- with the required newline in the
Changelog. :)

What's the workflow with respect to the bugzilla bug?  Am I supposed
to do something with the status?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #4 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-06 02:39:33 GMT ---
Marking it as Resolved -> NextRelease is most appropriate, although
CurrentRelease is what a lot of people do, so don't worry about exactly which
:-). 

Of course the terminology comes mostly from elsewhere. Strictly CurrentRelease
means the fix was made during the alpha or beta stage of the release process -
i.e. a release is in the works but not yet final. But there's no big deal about
it.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #4 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-06 02:39:33 GMT ---
Marking it as Resolved -> NextRelease is most appropriate, although
CurrentRelease is what a lot of people do, so don't worry about exactly which
:-). 

Of course the terminology comes mostly from elsewhere. Strictly CurrentRelease
means the fix was made during the alpha or beta stage of the release process -
i.e. a release is in the works but not yet final. But there's no big deal about
it.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

--- Comment #3 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-05 20:33:39 GMT ---
I've commited this change -- with the required newline in the
Changelog. :)

What's the workflow with respect to the bugzilla bug?  Am I supposed
to do something with the status?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-03 04:44:27 GMT ---
Reluctantly, simply due to the overwhelming number of warnings, I agree this
patch should go in. I guess we'll just have to think about updating the BSD
stack port at some point, if someone's got a free month or three.

Remember the extra ChangeLog newline though :-).

I think this is an exception to the rule that we should try and fix strict
aliasing problems. For example RedBoot has a bunch, and -fno-strict-aliasing
isn't appropriate there because it's our code, and it won't be fixed by a
future import from an upstream source.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001501] Fix warnings about type-punned pointers in bsd_tcpip code.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001501

--- Comment #1 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-01 15:01:17 GMT ---
If the warnings are all in ipv6 code, should CFLAGS only contain the
new flag if ipv6 code is enabled?  I'm inclined to leave CFLAGS the
same for both cases just to keep things consistent.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.