public inbox for ecos-bugs@sourceware.org help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001510] Fix compiler warnings about mismatch between log() format string and argument values. Date: Fri, 09 Mar 2012 14:57:00 -0000 [thread overview] Message-ID: <20120309145646.9FD5F2F78001@mail.ecoscentric.com> (raw) In-Reply-To: <bug-1001510-777@http.bugs.ecos.sourceware.org/> Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001510 --- Comment #8 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-09 14:56:42 GMT --- (In reply to comment #6) >>> You're right. Both fields in struct timeval are signed. tv_sec >>> is 'int' and tv_usec is 'long int'. > > I don't see that. Well, I "saw" it, but it wasn't really there... > The default is that in isoinfra, struct timeval is set to contain > two time_t's, which by default are ints. If POSIX is included, then > that is overridden[1] so it contains two longs. I don't see any mix > of int and long. Are you thinking of struct timespec instead? Yes, I was looking at the definition for timespec. > Although we're not yet in a position to convert wholesale to 64-bit > time_t, using long would not be sufficient when we did - it would > need to be long long and so %lld. > > But in the first instance, yes we could change time_t to a long. And > I'm attaching a patch to do that which I think I ought to commit > regardless. Comments? Agreed. > Even so, the format specifier for time_t does happen to be a particular > problem. So for this file, how about instead using something like: > > #define INTFORMAT(_t_) (sizeof(_t_) == sizeof(long long) ? "lld" : "ld") > > log(LOG_DEBUG, "%s: = %" INTFORMAT(tp->tv_sec) ".%06" INTFORMAT(tp->tv_usec) "\n", __FUNCTION__, That looks like a good solution. The evaluation of the the ternary expression should happen at compile time so it won't slow down the log() operation any. Unless anybody objects, I'll go ahead and commit that. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
next prev parent reply other threads:[~2012-03-09 14:57 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-02 22:16 [Bug 1001510] New: " bugzilla-daemon 2012-03-03 3:52 ` [Bug 1001510] " bugzilla-daemon 2012-03-03 16:12 ` bugzilla-daemon 2012-03-06 19:32 ` bugzilla-daemon 2012-03-06 22:05 ` bugzilla-daemon 2012-03-06 22:15 ` bugzilla-daemon 2012-03-09 3:38 ` bugzilla-daemon 2012-03-09 3:40 ` bugzilla-daemon 2012-03-09 14:57 ` bugzilla-daemon [this message] 2012-03-09 15:09 ` bugzilla-daemon 2012-03-09 16:40 ` bugzilla-daemon 2012-03-09 16:53 ` bugzilla-daemon 2012-03-13 14:38 ` bugzilla-daemon 2012-03-13 16:09 ` bugzilla-daemon -- strict thread matches above, loose matches on Subject: below -- 2012-03-02 22:16 [Bug 1001510] New: " bugzilla-daemon 2012-03-03 3:52 ` [Bug 1001510] " bugzilla-daemon 2012-03-03 16:12 ` bugzilla-daemon 2012-03-06 19:32 ` bugzilla-daemon 2012-03-06 22:04 ` bugzilla-daemon 2012-03-06 22:15 ` bugzilla-daemon 2012-03-09 3:39 ` bugzilla-daemon 2012-03-09 3:40 ` bugzilla-daemon 2012-03-09 14:57 ` bugzilla-daemon 2012-03-09 15:09 ` bugzilla-daemon 2012-03-09 16:40 ` bugzilla-daemon 2012-03-09 16:53 ` bugzilla-daemon 2012-03-13 14:38 ` bugzilla-daemon 2012-03-13 16:09 ` bugzilla-daemon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120309145646.9FD5F2F78001@mail.ecoscentric.com \ --to=bugzilla-daemon@bugs.ecos.sourceware.org \ --cc=unassigned@bugs.ecos.sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).