[Bug 1001525] New: Fix compiler warnings in bsd_tcpip files.

[Bug 1001525] New: Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

           Summary: Fix compiler warnings in bsd_tcpip files.
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: NEW
          Severity: minor
          Priority: low
         Component: TCP/IP
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: grant.b.edwards@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1625)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1625)
Fix compiler warnings in several bsd_tcpip files.

This patch fixes compiler warnings in several bsd_tcpip files
generated by gcc 4.6.2 (mostly about variables that are set and never
referenced).  This patch doesn't deal with files under netinet6 - they
will be handled in another patch.

Variables that were set but only referenced in conditionally compiled
code are marked with CYGBLD_ATTRIB_UNUSED.

Variables that were set but never referenced at all have been removed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001525] Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-09 03:50:11 GMT ---
Again this line in tcp_usr_attach(), tcp_usr_accept() and tcp6_usr_accept() in
tcp_usrreq.c:
+    CYGBLD_ATTRIB_UNUSED struct tcpcb *tp = 0;
should have the attribute at the end for consistency.

Apart from that it can go in. (No need to update patch here, nor in issue
1001526).

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001525] Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

--- Comment #2 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-09 15:02:53 GMT ---
(In reply to comment #1)

> +    CYGBLD_ATTRIB_UNUSED struct tcpcb *tp = 0;
> should have the attribute at the end for consistency.

Agreed.  I had always tried to put it after the initializer (which
doesn't compile).  It's embarassingly obvious now, but it hadn't
occurred to me that you can leave the attribute in the usual spot and
put the initializer assignment after the attribute.

I'll commit the this and 1001526 with the attribute moved.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001525] Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

Grant Edwards <grant.b.edwards@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #3 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-09 19:25:13 GMT ---
Committed changes:

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/ChangeLog,v  <--  ChangeLog
new revision: 1.77; previous revision: 1.76

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/net/if_ethersubr.c,v  <-- 
if_ethersubr.c
new revision: 1.7; previous revision: 1.6

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/ip_encap.c,v  <-- 
ip_encap.c
new revision: 1.3; previous revision: 1.2

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/tcp_input.c,v  <--
 tcp_input.c
new revision: 1.6; previous revision: 1.5

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/tcp_output.c,v 
<--  tcp_output.c
new revision: 1.5; previous revision: 1.4

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/tcp_usrreq.c,v 
<--  tcp_usrreq.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/udp_usrreq.c,v 
<--  udp_usrreq.c
new revision: 1.6; previous revision: 1.5

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001525] Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

Grant Edwards <grant.b.edwards@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #3 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-09 19:25:13 GMT ---
Committed changes:

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/ChangeLog,v  <--  ChangeLog
new revision: 1.77; previous revision: 1.76

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/net/if_ethersubr.c,v  <-- 
if_ethersubr.c
new revision: 1.7; previous revision: 1.6

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/ip_encap.c,v  <-- 
ip_encap.c
new revision: 1.3; previous revision: 1.2

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/tcp_input.c,v  <--
 tcp_input.c
new revision: 1.6; previous revision: 1.5

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/tcp_output.c,v 
<--  tcp_output.c
new revision: 1.5; previous revision: 1.4

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/tcp_usrreq.c,v 
<--  tcp_usrreq.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet/udp_usrreq.c,v 
<--  udp_usrreq.c
new revision: 1.6; previous revision: 1.5

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001525] Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

--- Comment #2 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-09 15:02:53 GMT ---
(In reply to comment #1)

> +    CYGBLD_ATTRIB_UNUSED struct tcpcb *tp = 0;
> should have the attribute at the end for consistency.

Agreed.  I had always tried to put it after the initializer (which
doesn't compile).  It's embarassingly obvious now, but it hadn't
occurred to me that you can leave the attribute in the usual spot and
put the initializer assignment after the attribute.

I'll commit the this and 1001526 with the attribute moved.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001525] Fix compiler warnings in bsd_tcpip files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001525

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-09 03:50:11 GMT ---
Again this line in tcp_usr_attach(), tcp_usr_accept() and tcp6_usr_accept() in
tcp_usrreq.c:
+    CYGBLD_ATTRIB_UNUSED struct tcpcb *tp = 0;
should have the attribute at the end for consistency.

Apart from that it can go in. (No need to update patch here, nor in issue
1001526).

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.