public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001569] Cortex-M arch. whitespace cleanup.
Date: Mon, 23 Apr 2012 17:08:00 -0000 [thread overview]
Message-ID: <20120423170821.963E42F78001@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001569-777@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569
--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 18:08:20 BST ---
(In reply to comment #5)
> (From update of attachment 1708 [details])
> Actually hold back on that commit. Just looking at the patch again, I noticed
> some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
> removal. For example in get_register():
> if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
> - return -1;
> + return -1;
>
> The return should still be indented. There are other examples, but only in that
> file. You can go ahead and commit on the assumption those are fixed.
Thank you for the catch. I found out few, but obviously not all. I'll clean up
the patch and repost it.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
next prev parent reply other threads:[~2012-04-23 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 7:17 [Bug 1001569] New: " bugzilla-daemon
2012-04-23 7:26 ` [Bug 1001569] " bugzilla-daemon
2012-04-23 15:36 ` bugzilla-daemon
2012-04-23 16:52 ` bugzilla-daemon
2012-04-23 16:54 ` bugzilla-daemon
2012-04-23 17:00 ` bugzilla-daemon
2012-04-23 17:08 ` bugzilla-daemon [this message]
2012-04-23 17:14 ` bugzilla-daemon
2012-04-23 17:55 ` bugzilla-daemon
2012-04-23 17:56 ` bugzilla-daemon
2012-04-23 19:24 ` bugzilla-daemon
2012-04-23 7:17 [Bug 1001569] New: " bugzilla-daemon
2012-04-23 7:26 ` [Bug 1001569] " bugzilla-daemon
2012-04-23 15:36 ` bugzilla-daemon
2012-04-23 16:52 ` bugzilla-daemon
2012-04-23 16:55 ` bugzilla-daemon
2012-04-23 17:00 ` bugzilla-daemon
2012-04-23 17:08 ` bugzilla-daemon
2012-04-23 17:14 ` bugzilla-daemon
2012-04-23 17:55 ` bugzilla-daemon
2012-04-23 17:55 ` bugzilla-daemon
2012-04-23 19:24 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423170821.963E42F78001@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=unassigned@bugs.ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).