[Bug 1001569] New: Cortex-M arch. whitespace cleanup.

[Bug 1001569] New: Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

           Summary: Cortex-M arch. whitespace cleanup.
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Cortex-M
            Status: NEW
          Severity: enhancement
          Priority: low
         Component: HAL
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: ilijak@siva.com.mk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1707)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1707)
Cortex-M arch whitespace cleanup

While preparing a considerable patch to Cortex-M architecture I noticed that
Cortex-M arch files contain some whitespace that (can) cause noise. I find it
wise to clean it up before submitting. Hence the attached patch.

Note: The attached patch does not touch Copyright banners.
Please comment.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1707|0                           |1
        is obsolete|                            |

--- Comment #1 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 08:26:22 BST ---
Created an attachment (id=1708)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1708)
Cortex-M arch whitespace cleanup 120423

In previous patch there was one discrepancy due to conversion of tabs to
spaces. Here's fixed patch.

Also I forgot to mention: There are two kinds of cleanup:
    - Convert tabs to spaces
    - Trim trailing whatespace.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 16:36:26 BST ---
I don't disagree with the principle and I have been looking forward to doing
this sort of thing myself, but would you mind this being held back until we
move to mercurial? Having these sweeping changes across many files is much
easier to deal with, and less noisy, once we have a system which groups such
changes into a single changeset.

There was a conversation before about fixing the trailing whitespace in
copyright banners, and I suggested waiting before doing that for the same
reason. At that point, we could probably remove all trailing whitespace from
the entire repo (excepting any binary files), not just cortex-m.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 17:51:50 BST ---
(In reply to comment #2)
> I don't disagree with the principle and I have been looking forward to doing
> this sort of thing myself, but would you mind this being held back until we
> move to mercurial? Having these sweeping changes across many files is much
> easier to deal with, and less noisy, once we have a system which groups such
> changes into a single changeset.

This clean-up has a purpose and it is to make provision for clean patch(es)
that I intend to post soon. I don't know the prospective for switching to
mercurial but I'm afraid it won't be in time-frame that I need (surprise me :)

The alternatives for this patch (unless there is a pleasent surprise) are
either to merge the clean-up with contribution or post "dirty" patches which
IMO both will produce more noise than this patch.
I am aware that CVS keeps different version number for each file but the
proposed patch is limited to a single package (with single ChangeLog).

> 
> There was a conversation before about fixing the trailing whitespace in
> copyright banners, and I suggested waiting before doing that for the same
> reason. At that point, we could probably remove all trailing whitespace from
> the entire repo (excepting any binary files), not just cortex-m.

Having that in mind I have left them intact.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #4 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 17:54:38 BST ---
(In reply to comment #3)
> 
> This clean-up has a purpose and it is to make provision for clean patch(es)
> that I intend to post soon.

If there's a specific reason, then that's fine, please go ahead and commit. If
it was just random cleanup just by itself for cosmetic reasons, then that's all
I was referring to.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1708|                            |assignment+, review+
               Flag|                            |

--- Comment #5 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 17:59:47 BST ---
(From update of attachment 1708)
Actually hold back on that commit. Just looking at the patch again, I noticed
some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
removal. For example in get_register():
     if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
-    return -1;
+    return -1;

The return should still be indented. There are other examples, but only in that
file. You can go ahead and commit on the assumption those are fixed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 18:08:20 BST ---
(In reply to comment #5)
> (From update of attachment 1708 [details])
> Actually hold back on that commit. Just looking at the patch again, I noticed
> some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
> removal. For example in get_register():
>      if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
> -    return -1;
> +    return -1;
> 
> The return should still be indented. There are other examples, but only in that
> file. You can go ahead and commit on the assumption those are fixed.

Thank you for the catch. I found out few, but obviously not all. I'll clean up
the patch and repost it.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #7 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 18:14:19 BST ---
No need to re-post for such a small change.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 18:55:02 BST ---
Created an attachment (id=1714)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1714)
Cortex-M arch whitespace cleanup 120423-1950

(In reply to comment #5)
> (From update of attachment 1708 [details])
> Actually hold back on that commit. Just looking at the patch again, I noticed
> some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
> removal. For example in get_register():
>      if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
> -    return -1;
> +    return -1;
> 
> The return should still be indented. There are other examples, but only in that
> file. You can go ahead and commit on the assumption those are fixed.

Fixed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1708|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #9 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 20:24:29 BST ---
Checked in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #9 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 20:24:29 BST ---
Checked in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1708|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 18:55:02 BST ---
Created an attachment (id=1714)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1714)
Cortex-M arch whitespace cleanup 120423-1950

(In reply to comment #5)
> (From update of attachment 1708 [details])
> Actually hold back on that commit. Just looking at the patch again, I noticed
> some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
> removal. For example in get_register():
>      if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
> -    return -1;
> +    return -1;
> 
> The return should still be indented. There are other examples, but only in that
> file. You can go ahead and commit on the assumption those are fixed.

Fixed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #7 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 18:14:19 BST ---
No need to re-post for such a small change.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 18:08:20 BST ---
(In reply to comment #5)
> (From update of attachment 1708 [details])
> Actually hold back on that commit. Just looking at the patch again, I noticed
> some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
> removal. For example in get_register():
>      if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
> -    return -1;
> +    return -1;
> 
> The return should still be indented. There are other examples, but only in that
> file. You can go ahead and commit on the assumption those are fixed.

Thank you for the catch. I found out few, but obviously not all. I'll clean up
the patch and repost it.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1708|                            |assignment+, review+
               Flag|                            |

--- Comment #5 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 17:59:47 BST ---
(From update of attachment 1708)
Actually hold back on that commit. Just looking at the patch again, I noticed
some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
removal. For example in get_register():
     if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
-    return -1;
+    return -1;

The return should still be indented. There are other examples, but only in that
file. You can go ahead and commit on the assumption those are fixed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #4 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 17:54:38 BST ---
(In reply to comment #3)
> 
> This clean-up has a purpose and it is to make provision for clean patch(es)
> that I intend to post soon.

If there's a specific reason, then that's fine, please go ahead and commit. If
it was just random cleanup just by itself for cosmetic reasons, then that's all
I was referring to.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 17:51:50 BST ---
(In reply to comment #2)
> I don't disagree with the principle and I have been looking forward to doing
> this sort of thing myself, but would you mind this being held back until we
> move to mercurial? Having these sweeping changes across many files is much
> easier to deal with, and less noisy, once we have a system which groups such
> changes into a single changeset.

This clean-up has a purpose and it is to make provision for clean patch(es)
that I intend to post soon. I don't know the prospective for switching to
mercurial but I'm afraid it won't be in time-frame that I need (surprise me :)

The alternatives for this patch (unless there is a pleasent surprise) are
either to merge the clean-up with contribution or post "dirty" patches which
IMO both will produce more noise than this patch.
I am aware that CVS keeps different version number for each file but the
proposed patch is limited to a single package (with single ChangeLog).

> 
> There was a conversation before about fixing the trailing whitespace in
> copyright banners, and I suggested waiting before doing that for the same
> reason. At that point, we could probably remove all trailing whitespace from
> the entire repo (excepting any binary files), not just cortex-m.

Having that in mind I have left them intact.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 16:36:26 BST ---
I don't disagree with the principle and I have been looking forward to doing
this sort of thing myself, but would you mind this being held back until we
move to mercurial? Having these sweeping changes across many files is much
easier to deal with, and less noisy, once we have a system which groups such
changes into a single changeset.

There was a conversation before about fixing the trailing whitespace in
copyright banners, and I suggested waiting before doing that for the same
reason. At that point, we could probably remove all trailing whitespace from
the entire repo (excepting any binary files), not just cortex-m.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001569] Cortex-M arch. whitespace cleanup.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1707|0                           |1
        is obsolete|                            |

--- Comment #1 from Ilija Kocho <ilijak@siva.com.mk> 2012-04-23 08:26:22 BST ---
Created an attachment (id=1708)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1708)
Cortex-M arch whitespace cleanup 120423

In previous patch there was one discrepancy due to conversion of tabs to
spaces. Here's fixed patch.

Also I forgot to mention: There are two kinds of cleanup:
    - Convert tabs to spaces
    - Trim trailing whatespace.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.