From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5096 invoked by alias); 4 May 2012 16:36:16 -0000 Received: (qmail 5044 invoked by uid 22791); 4 May 2012 16:36:15 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 May 2012 16:36:00 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id A8D542F78001 for ; Fri, 4 May 2012 17:35:59 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iUc669liPRXb; Fri, 4 May 2012 17:35:59 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1000910] New port: Ethernet over SPI driver for ENC424J600 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: jifl@ecoscentric.com X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 04 May 2012 16:36:00 -0000 Message-Id: <20120504163558.1ECF92F78006@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg00857.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000910 --- Comment #21 from Jonathan Larmour 2012-05-04 17:35:48 BST --- I have made a bunch of cosmetic updates and applied the patch, thanks! I will attach the updated version of the patch, along with the updates themselves. A lot of them were just whitespace changes, most especially in the CDL file. It now conforms to our existing practice much better, and in future you may want to watch out for the sort of things I changed if you submit patches in future. There are a few other textual changes too, and some fixes of changing things like cdl_components which should really be cdl_options. But nothing of great importance. Note, despite the earlier discussion, I have in the end changed the description of CYGHWR_HAL_CORTEXM_STM32_SPIETH_CONTROLLER because I realised that in the configuration tool, if the CYGPKG_DEVS_ETH_ENC424J600 package is not loaded, the package will be displayed at the top level, albeit inactive. With a title of just "STM3210E HAL resources", this might confuse some people. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.