From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6569 invoked by alias); 30 Sep 2012 19:17:58 -0000 Received: (qmail 6562 invoked by uid 22791); 30 Sep 2012 19:17:57 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Sep 2012 19:17:50 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 8776E2F78005 for ; Sun, 30 Sep 2012 20:17:49 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9kU9S-v8z+gu; Sun, 30 Sep 2012 20:17:49 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1000761] eCos support for MPC5xxx MCUs X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 30 Sep 2012 19:17:00 -0000 Message-Id: <20120930191745.A36672F7800F@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01278.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000761 --- Comment #59 from Ilija Kocho 2012-09-30 20:17:37 BST --- (In reply to comment #57) Hi Stefan. > Hi Ilija, > I have looked into your FlexCAN package and now I am confused about one thing: > In our original CDL file we looked at some of the definitions in the CDL file > of the HAL to determine, whether a certain device / platform actually has that > specific instance implemented. This was done by: > active_if CYGNUM_HAL_DEV_LIST_CAN[set ::canletter] > in the CAN.cdl > now you modified this to: > active_if CYGINT_DEVS_CAN_FREESCALE_FLEXCAN[set ::canletter] > My question is now about naming conventions. I assume, I can only set those in > the CDL files and I thought, that the HAL should use names like > CYGNUM_HAL_DEV_... to advertize its HW capabilities - is that not correct ? Regarding your CYGNUM_HAL_DEV_LIST... code, I haven't tried it but it looks correct to me... But, it's not just the naming. CYGINT_DEVS_CAN_FREESCALE_FLEXCAN[set ::canletter] introduces [CAN] cyg_interface(s) that platforms [can] implement. Generally, renaming of objects was a major part of my job during the conversion of the driver into generic, but in this case I took more liberty. I apologize if I have been too intrusive, but I think that interfaces are more intuitive. The usage is straightforward: Platforms implement certain device interface(s). Interfaces are widely used for implementing device instances through eCos code and I would recommend them also for other devices: serial channels, etc. Btw, In newer Freescale documents the enumeration is numeric rather than alphabetic. My experience is with Kinetis, but I think it is also applied to MPC/Qorivva. I don't insist but would ask you to consider, as it will simplify CDL code. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.