From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 388 invoked by alias); 1 Oct 2012 09:58:07 -0000 Received: (qmail 380 invoked by uid 22791); 1 Oct 2012 09:58:07 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 09:58:02 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 518192F78003 for ; Mon, 1 Oct 2012 10:58:01 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2MVl7ejcqW-A; Mon, 1 Oct 2012 10:58:01 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1000761] eCos support for MPC5xxx MCUs X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: bernd.edlinger@hotmail.de X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 01 Oct 2012 09:58:00 -0000 Message-Id: <20121001095752.9017A2F7800E@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01280.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000761 Bernd Edlinger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernd.edlinger@hotmail.de --- Comment #60 from Bernd Edlinger 2012-10-01 10:57:39 BST --- Hello Stefan, I was looking at this just for curiosity, and if it has a potential to break other ports in any way. Now there is one thing that is unclear to me, You said: > - some small SED script lines accross multiple locations (e.g. memalloc, > rules.mak) to work with MinGW build toolchains. I have seen many requests on > Forums for different architectures, where people were looking for this, so this > should be of generic interest. At this point in time the VLE enabled toolchains > are only available in MinGW build form. Well, I see there are changes in the sed scripts in 3 patches: Attachment #1866, Attachment #1867 and Attachment #1868. You changed @sed -e '/^ *\\/d' -e "s#.*: #$@: #" $(@:.o.d=.tmp) > $@ to @sed -e 's!c:/cygwin!!g' -e 's/c://g' -e '/^ *\\/d' -e "s#.*: #$@: #" $(@:.o.d=.tmp) > $@ @printf "\n" >> $@ I assume you have a GCC built under MinGW and the make built under Cygwin. and you try to remove drive letters to make the Cygwin-make understand the dependencies. But what I do not understand is this: 1. ":" is a quite normal character to a linux file system. so should'nt that all be controlled by a compile option? 2. this change seems only to handle the case when cygwin is installed under c:\cywin, however Cygwin could also be installed in d:\cygwin, or even d:\tools\Cygwin. 3. at one place it looks slightly different: @sed -e 's!c:/cygwin!!g' -e 's/c://g' -e 's!c:\cygwin!!g' ppc_offsets.tmp > ppc_offsets1.tmp should'nt this c:\ also be handled at the other places? 4. especially replacing every "c:" with "" looks wrong, because if a DOS-file is "X:\path\file.c" its Cywin-Path looks like "/cygdrive/x/path/file.c" 5. Are we sure that "printf" is always installed, like "sed"? I have never seen this tool was used before, why dont you use an "echo" here which is alredy used at many other places? Regards, Bernd Edlinger -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.