From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29990 invoked by alias); 5 Oct 2012 13:06:26 -0000 Received: (qmail 29982 invoked by uid 22791); 5 Oct 2012 13:06:26 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Oct 2012 13:06:19 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 67D6A2F78009 for ; Fri, 5 Oct 2012 14:06:18 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hlChInkacKTD; Fri, 5 Oct 2012 14:06:18 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1000761] eCos support for MPC5xxx MCUs X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 05 Oct 2012 13:06:00 -0000 Message-Id: <20121005130608.7B2C52F78010@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01285.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000761 --- Comment #61 from Ilija Kocho 2012-10-05 14:05:54 BST --- (In reply to comment #58) Hi Stefan > Hi ecos Maintainers, Jonathan, > any progress on the review of our contribution ? It has almost been two months > and we heard nothing so far. I was hoping, that active contributions are more > appreciated ?! In comment #32 and comment #33 Jifl mentiond duplicate files, and they are still present in recent attachment #1872 (aka /MPC5xxx HAL packages/ ). There are a lot of definitions repeating across /include/ directories of all platforms, in files such as: var_regs.h, mpc5*.h, plf_intr.h, etc. These can, and should be consolidated in respective files placed in var/current/include directory. Also some of these files, notably mpc5*.h have copyright banners that are incompatible with eCos licence. This is my impression, but could the number of platforms be reduced, at least for initial port? I have impression that the aim is to cover every chip (which is not bad) but could some of these platforms be consolidated? It will make the review and maintenance easier. Regards Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.