From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4937 invoked by alias); 14 Oct 2012 15:23:32 -0000 Received: (qmail 4930 invoked by uid 22791); 14 Oct 2012 15:23:31 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 14 Oct 2012 15:23:26 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 402872F7800A for ; Sun, 14 Oct 2012 16:23:25 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Un4SESTmTxEr; Sun, 14 Oct 2012 16:23:25 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1000761] eCos support for MPC5xxx MCUs X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 14 Oct 2012 15:23:00 -0000 Message-Id: <20121014152323.4908F2F7800E@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01297.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000761 --- Comment #62 from Ilija Kocho 2012-10-14 16:23:04 BST --- (Addendum to comment #61) > (In reply to comment #58) > > Hi Stefan > > > Hi ecos Maintainers, Jonathan, > > any progress on the review of our contribution ? It has almost been two months > > and we heard nothing so far. I was hoping, that active contributions are more > > appreciated ?! > > In comment #32 and comment #33 Jifl mentiond duplicate files, and they are > still present in recent attachment #1872 [details] (aka /MPC5xxx HAL packages/ ). > There are a lot of definitions repeating across /include/ directories of all > platforms, in files such as: var_regs.h, mpc5*.h, plf_intr.h, etc. These can, > and should be consolidated in respective files placed in var/current/include > directory. > > Also some of these files, notably mpc5*.h have copyright banners that are > incompatible with eCos licence. > Most of these definitions are actually for devices. The definitions related to peripherals that have I/O device drivers, (for example FlexCAN) should live in respective driver directories. That will decouple them from the HAL and aid design of generic drivers. (Just to note, I also see some redundant definitions such as ESCI.) As a guide, var_io.h should contain definitions for peripherals that do not belong to IO subsystem: clocking, interrupt controller, system integration, clock/power management, etc. Here also comes DMA, and I FYI there is a generic eDMA library under packages/hal/misc/freescale/edma. Following peripherals combined with diverse Freescale architectures have generic eCos drivers (that include headers): - ESCI - FlexCAN (the converted driver) - DSPI (uses eDMA) - Ethernet - UART - I2C (Last one in bug 1001397). > This is my impression, but could the number of platforms be reduced, at least > for initial port? I have impression that the aim is to cover every chip (which > is not bad) but could some of these platforms be consolidated? It will make the > review and maintenance easier. > > Regards > > Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.