From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26695 invoked by alias); 29 Oct 2012 10:05:42 -0000 Received: (qmail 26679 invoked by uid 22791); 29 Oct 2012 10:05:41 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Oct 2012 10:05:36 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 0C5302F7800F for ; Mon, 29 Oct 2012 10:05:35 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j9Vl-TAQ3-VG; Mon, 29 Oct 2012 10:05:34 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1000761] eCos support for MPC5xxx MCUs X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: Stefan.Singer@freescale.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 29 Oct 2012 10:05:00 -0000 Message-Id: <20121029100533.5BECA2F78011@mail.ecoscentric.com> Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01315.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000761 --- Comment #64 from Stefan Singer 2012-10-29 10:05:31 GMT --- Hi Ilija, I am a bit confused about your two last posts. Our intention was to split the drivers into a generic part, which is put into the dev section and the device dependent definitions, which I did put into the HAL section. The rational was, that the MPC5xxx family spans now over 3 device technologies 130, 90, 55 nm and more than 8 years and that obviously a number of things have changed despite some generic base architecture. Therefore our attempt to split the drivers in a way like this. Are you proposing, that we should remove those device dependent definitions from the HAL and have a separate folder for each device in the dev section ? Notably the following 3 files exist in every platform: - var_regs.h: Register definitions in the eCos style. Of course there is overlap with the device header file, since certain definitions exist in both files, but this file is done in the way used in many other eCOS platforms and the other file is reused from the Freescale website. - mpc5*.h: This is the device definition header file for each device take directly from our website. I tried to use that unmodified, however in some instances I needed to make small adjustments, so that the common drivers find common definitions. Since the spirit was to try to use those files unmodified from the website, that are also the only files (at least that was my attention), where there is a different copyright, since otherwise I would need to modify those files. - plf_intr.h: Interrupt Mapping for each device. This must be different for each device. There are of course common sections accross multiple files, but not two will be identical. Can you please help me to understand, what I should change now ? I would not like to remove the support for some devices to have less files to review - that sounds wrong to me. I am still struggling to understand what you expect here. I know that you are pushing to reuse the eCos drivers from other peripherals and we will try to do that on some, but e.g. the new Flexcan driver does not work yet at all (although I have already invested quite some time in it). Thanks Stefan -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.