[Bug 1001096] New: Dual Init of SPI on at91sam7x-based system

[Bug 1001096] New: Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

           Summary: Dual Init of SPI on at91sam7x-based system
           Product: eCos
           Version: CVS
          Platform: Other (please specify)
        OS/Version: ARM
            Status: UNCONFIRMED
          Severity: critical
          Priority: low
         Component: SPI
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: Bob.Brusa@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Using cvs, I downloaded the current version of eCos on 1-Dec-2010. I then added
my hardware and my template and built a library. This and the following work
was done with the toolchain that came with eCos-3.0 (hence gcc v 4.3.2).

When executing a small program that was built using this library, it produces
an ASSERT FAIL, because it tries to configure an already used interrupt. Using
the debugger I find, that the SPI-bus0 is initialized twice. The loop in
hal_misc.c

    for (p = &CONSTRUCTORS_START; p != CONSTRUCTORS_END; NEXT_CONSTRUCTOR(p))
        (*p)();

calls the spi-bus0-initialization twice (two lines copied from the debugger):

2 cyg_spi_at91_bus_init() spi_at91.c:196 0x00104eb0    
1 cyg_hal_invoke_constructors() hal_misc.c:213 0x00103f04

For further details please also check the ecos-discuss mailing list subject:
[ECOS] Dual Init of SPI on at91sam7x-based system. There, two different fixes
are reported and I know that the fix proposed by Christophe Coutand works, but
it is probably rather special and will not work for other configurations.
I hope you have a fix for this problem - Robert

PS: If you need the ecc and my hardware-package and template to reproduce the
error, please let me know.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001096] Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

Robert Brusa <Bob.Brusa@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|low                         |high

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001096] Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

--- Comment #1 from Christophe Coutand <ecos@hotmail.co.uk> 2010-12-09 18:59:20 GMT ---
Created an attachment (id=1049)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1049)
Make CYGBLD_ATTRIB_C_INIT_PRI visible from C++ files

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001096] Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

--- Comment #2 from Christophe Coutand <ecos@hotmail.co.uk> 2010-12-09 19:00:56 GMT ---
Created an attachment (id=1050)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1050)
Prevent C constructor from spi_at91.c to be removed by linker, place object in
libextras.a

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001096] Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

--- Comment #3 from Christophe Coutand <ecos@hotmail.co.uk> 2010-12-09 19:01:49 GMT ---
Created an attachment (id=1051)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1051)
Prevent C constructor from spi_stm32.c to be removed by linker, place object in
libextras.a

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001096] Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos@hotmail.co.uk

--- Comment #4 from Christophe Coutand <ecos@hotmail.co.uk> 2010-12-09 19:05:21 GMT ---
Hi,

Here is a set of small patches to correct the problem. Both C and C++
constructor shall work now. I don't see that making CYGBLD_ATTRIB_C_INIT_PRI
visible from C++ files is a problem, I might be wrong.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001096] New: Dual Init of SPI on at91sam7x-based system

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001096

           Summary: Dual Init of SPI on at91sam7x-based system
           Product: eCos
           Version: CVS
          Platform: Other (please specify)
        OS/Version: ARM
            Status: UNCONFIRMED
          Severity: critical
          Priority: low
         Component: SPI
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: Bob.Brusa@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Using cvs, I downloaded the current version of eCos on 1-Dec-2010. I then added
my hardware and my template and built a library. This and the following work
was done with the toolchain that came with eCos-3.0 (hence gcc v 4.3.2).

When executing a small program that was built using this library, it produces
an ASSERT FAIL, because it tries to configure an already used interrupt. Using
the debugger I find, that the SPI-bus0 is initialized twice. The loop in
hal_misc.c

    for (p = &CONSTRUCTORS_START; p != CONSTRUCTORS_END; NEXT_CONSTRUCTOR(p))
        (*p)();

calls the spi-bus0-initialization twice (two lines copied from the debugger):

2 cyg_spi_at91_bus_init() spi_at91.c:196 0x00104eb0    
1 cyg_hal_invoke_constructors() hal_misc.c:213 0x00103f04

For further details please also check the ecos-discuss mailing list subject:
[ECOS] Dual Init of SPI on at91sam7x-based system. There, two different fixes
are reported and I know that the fix proposed by Christophe Coutand works, but
it is probably rather special and will not work for other configurations.
I hope you have a fix for this problem - Robert

PS: If you need the ecc and my hardware-package and template to reproduce the
error, please let me know.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.