[Bug 1001243] New: Fix trace function reporting of rewinddir()

[Bug 1001243] New: Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

           Summary: Fix trace function reporting of rewinddir()
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Filesystem support
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: manuel@matronix.de
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1262)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1262)
Fix tracing of rewinddir function

While trying to get the ATHTTPD server working, I found a bug in the file I/O
subsystem. I guess it only occures when tracing and assertions are turned on.

The Assertion I got, when accessing a webpage:

ASSERT FAIL: <6>cyg_trac.h[666]void Cyg_TraceFunction_Report_::set_exitvoid()
exitvoid used in typed function
ASSERT FAIL: <6>cyg_trac.h          [ 666] void
Cyg_TraceFunction_Report_::set_exitvoid()                                      
                exitvoid used in typed function


I hunted it down to the rewinddir() function. rewinddir returns void, which
fails because the macro FILEIO_ENTRY uses CYG_REPORT_FUNCTYPE( "returning %d"
), which sets a string for return.

rewinddir seems to be the only function returning void.
I fixed the problem by introducing a macro FILEIO_ENTRY_VOID which simply uses
CYG_REPORT_FUNCTION();

Find the patch attached and feel free to integrate it in CVS.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

Manuel Borchers <manuel@matronix.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|low                         |normal
                 CC|                            |manuel@matronix.de
           Severity|enhancement                 |normal

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

--- Comment #1 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-15 09:52:32 BST ---
Hi Manuel,

Thank you for investigation and the patch. Could you please send here
and ChangeLog entry?

Thanks,
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

--- Comment #2 from Manuel Borchers <manuel@matronix.de> 2011-08-15 16:29:57 BST ---
I'm about to go out to vacation. I'll prepare it when I'm back (~ 1.5 weeks).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-15 18:43:53 BST ---
(In reply to comment #2)                                                        
> I'm about to go out to vacation. I'll prepare it when I'm back (~ 1.5         
> weeks).                                                                       

No problem. If you want I can add the record if you permit to use your          
e-mail address which you used here.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1262|0                           |1
        is obsolete|                            |

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-16 12:59:48 BST ---
Created an attachment (id=1340)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1340)
Fix tracing of rewinddir(), +ChangeLog

Added ChangeLog entry.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-16 18:11:50 BST ---
Checked-in.

Thank you for your contribution to eCos.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001243] New: Fix trace function reporting of rewinddir()

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001243

           Summary: Fix trace function reporting of rewinddir()
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Filesystem support
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: manuel@matronix.de
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1262)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1262)
Fix tracing of rewinddir function

While trying to get the ATHTTPD server working, I found a bug in the file I/O
subsystem. I guess it only occures when tracing and assertions are turned on.

The Assertion I got, when accessing a webpage:

ASSERT FAIL: <6>cyg_trac.h[666]void Cyg_TraceFunction_Report_::set_exitvoid()
exitvoid used in typed function
ASSERT FAIL: <6>cyg_trac.h          [ 666] void
Cyg_TraceFunction_Report_::set_exitvoid()                                      
                exitvoid used in typed function


I hunted it down to the rewinddir() function. rewinddir returns void, which
fails because the macro FILEIO_ENTRY uses CYG_REPORT_FUNCTYPE( "returning %d"
), which sets a string for return.

rewinddir seems to be the only function returning void.
I fixed the problem by introducing a macro FILEIO_ENTRY_VOID which simply uses
CYG_REPORT_FUNCTION();

Find the patch attached and feel free to integrate it in CVS.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.