public inbox for ecos-bugs@sourceware.org help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001268] I2C driver for STM32 Cortex M3 Date: Wed, 03 Apr 2013 16:28:00 -0000 [thread overview] Message-ID: <bug-1001268-777-xLlQlvuJsN@http.bugs.ecos.sourceware.org/> (raw) In-Reply-To: <bug-1001268-777@http.bugs.ecos.sourceware.org/> Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001268 --- Comment #5 from Mike Jones <mjones@linear.com> --- Created attachment 2151 --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2151&action=edit Update STM32 I2C Support I tried to contact Martin to see if he had updated code he was willing to contribute, etc, but so far no reply. I am posting a patch. The patch contains: - Updated init function and base defines so that the I2C support works on a STM3240G-EVAL and should work for other STM32F4XX devices. - Attempted to preserve STM32F1XX support but have no means to test - Added support for SMBus timeout - Fixed fast mode clock calculation - Tested with PMBus/SMBus application consisting of three devices - Tested with polling and interrupt driven modes - Added loopback test for others to use Some areas that may warrant change. - The alternate pin assignments are set to the other two pins, but this is not flexible in that it will not adapt to a custom design. It could be improved to enter arbitrary pins in the CDL. - The second I2C is not set to any particular pins of importance and could use the same flexibility. - The ACK portion of the I2C API is not active in the code. This prevents lockups. If there is ever a reason to allow control it could be added, but it needs some thought as to how to prevent lockup. - The clock speed is ignored if changed in the instantiation of the i2c struct. A code override may be added in the future if desired. There is an inconsistency with the Kinetis driver. Kinetis I2C takes a period in the CDL. I think this should be changed to frequency and will change it when other work by Ilija completes. On the eval board this code was reliable in with a real application. Overtime it will get more use and I will fix anything I find. I would not hesitate to use the patch if you need I2C on this platform. However, if anyone has a board with STM32F1XX it would help to test this patch to ensure that version still works. The difference between F1 and F4 is in the GPIO configuration registers. I made almost no changes to the core code, so if it does not work, it is almost certain to be in the init code. I believe Martin has an assignment. I have one. So we should be able to get this into the codebase. -- You are receiving this mail because: You are the assignee for the bug.
prev parent reply other threads:[~2013-04-03 16:28 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-21 15:58 [Bug 1001268] New: " bugzilla-daemon 2011-06-21 20:30 ` [Bug 1001268] " bugzilla-daemon 2011-06-21 20:43 ` bugzilla-daemon 2011-06-22 13:05 ` bugzilla-daemon 2013-04-03 16:28 ` bugzilla-daemon [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-1001268-777-xLlQlvuJsN@http.bugs.ecos.sourceware.org/ \ --to=bugzilla-daemon@bugs.ecos.sourceware.org \ --cc=unassigned@bugs.ecos.sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).