public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug 1001439] New: can_lpc2xxx.c: CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems
@ 2012-01-03 11:20 bugzilla-daemon
2012-01-05 13:03 ` [Bug 1001439] " bugzilla-daemon
0 siblings, 1 reply; 3+ messages in thread
From: bugzilla-daemon @ 2012-01-03 11:20 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001439
Summary: can_lpc2xxx.c:
CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems
Product: eCos
Version: CVS
Platform: Other (please specify)
OS/Version: Cortex-M
Status: UNCONFIRMED
Severity: minor
Priority: low
Component: CAN
AssignedTo: unassigned@bugs.ecos.sourceware.org
ReportedBy: bernard.fouche@kuantic.com
CC: ecos-bugs@ecos.sourceware.org
Class: Advice Request
In function lpc2xxx_can_DSR():
...
#if CYGINT_IO_CAN_CHANNELS > 1
cyg_uint8 i = 0;
while (lpc2xxx_global_can_info.active_channels[i])
#endif // CYGINT_IO_CAN_CHANNELS > 1
{
cyg_uint32 icr;
can_channel *chan = LPC2XXX_GET_CAN_CHANNEL(lpc2xxx_global_can_info,
i++);
CAN_DECLARE_INFO(chan);
HAL_READ_UINT32(CAN_CTRL_ICR(info), icr); // this read clears ICR
#ifdef CYGOPT_DEVS_CAN_LPC2XXX_LUT_ERR_SUPP
// Set ICR_LUT_ERR flag only for controller which cause LUT error
if ((luterr_chan0 == i) || (luterr_chan1 == i))
...
1) 'i' is declared only if more than one CAN channel. 'i' is referenced always
if CYGOPT_DEVS_CAN_LPC2XXX_LUT_ERR_SUPP is defined.
2) On MCU counting CAN channels from 0: 'i++' is performed at beginning of
while(...), and if CYGOPT_DEVS_CAN_LPC2XXX_LUT_ERR_SUPP is defined,
luterr_chan[0/1] are compared to 'i': the LUT fault won't be reported to the
correct CAN channel for such MCUs (luterr_chan[0/1] have values directly
provided by the hardware). can_accfilt_lpc2xxx.c has macro
LPC2XXX_CAN_FIRST_IN_LUT that could be moved to can_lpc2xxx.h to help solve
this.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug 1001439] can_lpc2xxx.c: CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems
2012-01-03 11:20 [Bug 1001439] New: can_lpc2xxx.c: CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems bugzilla-daemon
@ 2012-01-05 13:03 ` bugzilla-daemon
0 siblings, 0 replies; 3+ messages in thread
From: bugzilla-daemon @ 2012-01-05 13:03 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001439
--- Comment #1 from Bernard Fouché <bernard.fouche@kuantic.com> 2012-01-05 13:03:19 GMT ---
The bug is more subtle: the loop:
...
while (lpc2xxx_global_can_info.active_channels[i])
...
will forbid processing of CAN channels that are not sequential from zero. For
instance if you only activate /dev/can1 and not /dev/can0, since
lpc2xxx_global_can_info.active_channels[0] is zero, the loop stops here and
/dev/can1 isn't processed. Being replaced by a 'for()' loop in updated driver.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
>From ecos-bugs-return-8607-listarch-ecos-bugs=sources.redhat.com@sourceware.org Thu Jan 05 13:03:38 2012
Return-Path: <ecos-bugs-return-8607-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-ecos-bugs@sources.redhat.com
Received: (qmail 18316 invoked by alias); 5 Jan 2012 13:03:37 -0000
Received: (qmail 18298 invoked by uid 22791); 5 Jan 2012 13:03:36 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0
tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jan 2012 13:03:23 +0000
Received: by mail.ecoscentric.com (Postfix, from userid 48)
id 7D1E92F78004; Thu, 5 Jan 2012 13:03:22 +0000 (GMT)
X-Original-To: unassigned@bugs.ecos.sourceware.org
Delivered-To: unassigned@bugs.ecos.sourceware.org
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001439] can_lpc2xxx.c:
CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCos
X-Bugzilla-Component: CAN
X-Bugzilla-Keywords:
X-Bugzilla-Severity: minor
X-Bugzilla-Who: bernard.fouche@kuantic.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: low
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
In-Reply-To: <bug-1001439-777@http.bugs.ecos.sourceware.org/>
References: <bug-1001439-777@http.bugs.ecos.sourceware.org/>
X-Bugzilla-URL: http://bugs.ecos.sourceware.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Date: Thu, 05 Jan 2012 13:03:00 -0000
Message-Id: <20120105130320.E0FE62F78004@mail.ecoscentric.com>
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
Delivered-To: mailing list ecos-bugs@sourceware.org
X-SW-Source: 2012/txt/msg00036.txt.bz2
Content-length: 800
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001439
--- Comment #1 from Bernard Fouché <bernard.fouche@kuantic.com> 2012-01-05 13:03:19 GMT ---
The bug is more subtle: the loop:
...
while (lpc2xxx_global_can_info.active_channels[i])
...
will forbid processing of CAN channels that are not sequential from zero. For
instance if you only activate /dev/can1 and not /dev/can0, since
lpc2xxx_global_can_info.active_channels[0] is zero, the loop stops here and
/dev/can1 isn't processed. Being replaced by a 'for()' loop in updated driver.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
>From ecos-bugs-return-8608-listarch-ecos-bugs=sources.redhat.com@sourceware.org Thu Jan 05 13:06:30 2012
Return-Path: <ecos-bugs-return-8608-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-ecos-bugs@sources.redhat.com
Received: (qmail 19248 invoked by alias); 5 Jan 2012 13:06:28 -0000
Received: (qmail 19239 invoked by uid 22791); 5 Jan 2012 13:06:27 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0
tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jan 2012 13:06:14 +0000
Received: from localhost (hagrid.ecoscentric.com [127.0.0.1])
by mail.ecoscentric.com (Postfix) with ESMTP id BAB062F7800A
for <ecos-bugs@ecos.sourceware.org>; Thu, 5 Jan 2012 13:06:13 +0000 (GMT)
Received: from mail.ecoscentric.com ([127.0.0.1])
by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id B-itSk7oVr4P; Thu, 5 Jan 2012 13:06:08 +0000 (GMT)
From: bugzilla-daemon@ecoscentric.com
To: ecos-bugs@ecos.sourceware.org
Subject: [Issue 1001228] 'char *' should be 'const char *' in the function
'cyg_thread_creat'
X-Bugzilla-Reason: QAcontact CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCosPro
X-Bugzilla-Component: Kernel
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: marwijn.hessel@altenpts.nl
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: normal
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Group Class Component Platform Version Product
In-Reply-To: <bug-1001228-13@http.bugzilla.ecoscentric.com/>
References: <bug-1001228-13@http.bugzilla.ecoscentric.com/>
X-Bugzilla-URL: http://bugzilla.ecoscentric.com/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Thu, 05 Jan 2012 13:06:00 -0000
Message-Id: <20120105130608.CB77C2F78006@mail.ecoscentric.com>
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
Delivered-To: mailing list ecos-bugs@sourceware.org
X-SW-Source: 2012/txt/msg00037.txt.bz2
Content-length: 889
Please do not reply to this email. Use the web interface provided at:
https://bugzilla.ecoscentric.com/show_bug.cgi?id\x1001228
Marwijn <marwijn.hessel@altenpts.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group| |eCosPro, ALSTOM
Class|Advice Request |Bug Report
Component|Kernel |Kernel
Platform|All |Custom (Customer specific)
Version|3.0 |3.1.2
Product|eCos |eCosPro
--
Configure issuemail: https://bugzilla.ecoscentric.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the issue.
You are on the CC list for the issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug 1001439] New: can_lpc2xxx.c: CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems
@ 2012-01-03 11:20 bugzilla-daemon
0 siblings, 0 replies; 3+ messages in thread
From: bugzilla-daemon @ 2012-01-03 11:20 UTC (permalink / raw)
To: unassigned
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001439
Summary: can_lpc2xxx.c:
CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems
Product: eCos
Version: CVS
Platform: Other (please specify)
OS/Version: Cortex-M
Status: UNCONFIRMED
Severity: minor
Priority: low
Component: CAN
AssignedTo: unassigned@bugs.ecos.sourceware.org
ReportedBy: bernard.fouche@kuantic.com
CC: ecos-bugs@ecos.sourceware.org
Class: Advice Request
In function lpc2xxx_can_DSR():
...
#if CYGINT_IO_CAN_CHANNELS > 1
cyg_uint8 i = 0;
while (lpc2xxx_global_can_info.active_channels[i])
#endif // CYGINT_IO_CAN_CHANNELS > 1
{
cyg_uint32 icr;
can_channel *chan = LPC2XXX_GET_CAN_CHANNEL(lpc2xxx_global_can_info,
i++);
CAN_DECLARE_INFO(chan);
HAL_READ_UINT32(CAN_CTRL_ICR(info), icr); // this read clears ICR
#ifdef CYGOPT_DEVS_CAN_LPC2XXX_LUT_ERR_SUPP
// Set ICR_LUT_ERR flag only for controller which cause LUT error
if ((luterr_chan0 == i) || (luterr_chan1 == i))
...
1) 'i' is declared only if more than one CAN channel. 'i' is referenced always
if CYGOPT_DEVS_CAN_LPC2XXX_LUT_ERR_SUPP is defined.
2) On MCU counting CAN channels from 0: 'i++' is performed at beginning of
while(...), and if CYGOPT_DEVS_CAN_LPC2XXX_LUT_ERR_SUPP is defined,
luterr_chan[0/1] are compared to 'i': the LUT fault won't be reported to the
correct CAN channel for such MCUs (luterr_chan[0/1] have values directly
provided by the hardware). can_accfilt_lpc2xxx.c has macro
LPC2XXX_CAN_FIRST_IN_LUT that could be moved to can_lpc2xxx.h to help solve
this.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-03 11:20 [Bug 1001439] New: can_lpc2xxx.c: CYGOPT_DEVS_CAN_CAN_LPC2XXX_LUT_ERR_SUPP problems bugzilla-daemon
2012-01-05 13:03 ` [Bug 1001439] " bugzilla-daemon
-- strict thread matches above, loose matches on Subject: below --
2012-01-03 11:20 [Bug 1001439] New: " bugzilla-daemon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).