[Bug 1001477] New: TERMIOS does not completely respect OPOST

[Bug 1001477] New: TERMIOS does not completely respect OPOST

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001477

           Summary: TERMIOS does not completely respect OPOST
           Product: eCos
           Version: 3.0
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: low
         Component: Serial
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: adam.gregory@roke.co.uk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Hi,

As far as I can tell, in termios, if the OPOST bit of c_oflag is not set, then
termios shouldn't wrangle the output characters regardless of the other flags.

However in ecos 3.0, io/serial/v3_0/src/common/termiostty.c line 612 reads:

   if ( (*buf == '\n') && (priv->termios.c_oflag & (OPOST|ONLCR)) ) {

Should this be (OPOST&ONLCR)?

This tripped me up quite badly trying to use a binary UART interface to an
external device using code originally written for UNIX that just cleared OPOST.
ONLCR seems to be set by default.

Apologies if this has already been fixed in CVS.

Regards,
Adam

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001477] TERMIOS does not completely respect OPOST

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001477

--- Comment #1 from Adam Gregory <adam.gregory@roke.co.uk> 2012-02-08 15:00:25 GMT ---
Sorry, I meant I think the condition should be:

if ( (*buf == '\n') && ((priv->termios.c_oflag & (OPOST|ONLCR)) ==
(OPOST|ONLCR)) )

Cheers,
Adam

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001477] New: TERMIOS does not completely respect OPOST

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001477

           Summary: TERMIOS does not completely respect OPOST
           Product: eCos
           Version: 3.0
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: low
         Component: Serial
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: adam.gregory@roke.co.uk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Hi,

As far as I can tell, in termios, if the OPOST bit of c_oflag is not set, then
termios shouldn't wrangle the output characters regardless of the other flags.

However in ecos 3.0, io/serial/v3_0/src/common/termiostty.c line 612 reads:

   if ( (*buf == '\n') && (priv->termios.c_oflag & (OPOST|ONLCR)) ) {

Should this be (OPOST&ONLCR)?

This tripped me up quite badly trying to use a binary UART interface to an
external device using code originally written for UNIX that just cleared OPOST.
ONLCR seems to be set by default.

Apologies if this has already been fixed in CVS.

Regards,
Adam

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.