From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29943 invoked by alias); 27 Jul 2012 10:37:44 -0000 Received: (qmail 29924 invoked by uid 22791); 27 Jul 2012 10:37:44 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jul 2012 10:37:25 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id B6F322F7800E for ; Fri, 27 Jul 2012 11:37:24 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZxtUskY7gFGC; Fri, 27 Jul 2012 11:37:23 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1001635] New: wrong results from Cyg_StdioStream::read X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: C library X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: bernd.edlinger@hotmail.de X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 27 Jul 2012 10:37:00 -0000 Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01096.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001635 Summary: wrong results from Cyg_StdioStream::read Product: eCos Version: CVS Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: normal Component: C library AssignedTo: unassigned@bugs.ecos.sourceware.org ReportedBy: bernd.edlinger@hotmail.de CC: ecos-bugs@ecos.sourceware.org Class: Advice Request Created an attachment (id=1849) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1849) proposed patch to fix this defect. there are several different code paths which can lead to wrong results in the function Cyg_StdioStream::read(). Please have a look at the following file: "ecos/packages/language/c/libc/stdio/current/src/common/stream.cxx". Suppose we are in unbuffered mode. There may be an unread character in the "ungetc" buffer. And there may be an unread character in the "readbuf_char" buffer. Then the code may go thru the if statement in line 340, and later thru the if statement in line 382. BUG: in line 384: *bytes_read = 1; is wrong, we have 2 bytes read. Now suppose we are in unbuffered mode again. There may be an unread character in the "ungetc" buffer. And the buffer_length may be 3 or higher. Then the code may go thru the if statement in line 340, and later thru the if statement in line 394. BUG: user_buffer was already incremented in line 341. So the returned data will contain an uninitialized byte in the middle. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.